-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-14914][CORE][SQL] Skip/fix some test cases on Windows due to limitation of Windows #15320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… FsHistoryProviderSuite
|
cc @srowen BTW, now I wrote some bunch of scripts and configurations for AppVeyor so I am able to run each test on Windows (except for PySpark). I will run the tests against this PR and post a comment just in case just to make sure. |
|
Sorry for being noisy, but I am thinking of sweeping the tests failed on Windows by skipping the tests across Spark (like repeating running the tests from scratch until I can't proceed further and then disabling them for each module) and then fixing them bit by bit (maybe each logically related group). It seems some PRs for Windows tests are arbitrarily being submitted. Do you think it makes sense? |
|
Test build #66214 has finished for PR 15320 at commit
|
|
Thanks - merging in master. |
What changes were proposed in this pull request?
This PR proposes to fix/skip some tests failed on Windows. This PR takes over #12696.
Before
SparkSubmitSuite
DiskStoreSuite
After
SparkSubmitSuite
DiskStoreSuite
For
CreateTableAsSelectSuiteandFsHistoryProviderSuite, I could not reproduce as the Java version seems higher than the one that has the bugs aboutsetReadable(..)andsetWritable(...)but as they are bugs reported clearly, it'd be sensible to skip those. We should revert the changes for both back as soon as we drop the support of Java 7.How was this patch tested?
Manually tested via AppVeyor.
Closes #12696