Skip to content

[SPARK-17685][SQL] Make SortMergeJoinExec's currentVars is null when calling createJoinKey #15259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-17685][SQL] Make SortMergeJoinExec's currentVars is null when calling createJoinKey #15259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,7 @@ case class SortMergeJoinExec(
keys: Seq[Expression],
input: Seq[Attribute]): Seq[ExprCode] = {
ctx.INPUT_ROW = row
ctx.currentVars = null
keys.map(BindReferences.bindReference(_, input).genCode(ctx))
}

Expand Down
9 changes: 9 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/DataFrameJoinSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,4 +248,13 @@ class DataFrameJoinSuite extends QueryTest with SharedSQLContext {
val ab = a.join(b, Seq("a"), "fullouter")
checkAnswer(ab.join(c, "a"), Row(3, null, 4, 1) :: Nil)
}

test("SPARK-17685: WholeStageCodegenExec throws IndexOutOfBoundsException") {
val df = Seq((1, 1, "1"), (2, 2, "3")).toDF("int", "int2", "str")
val df2 = Seq((1, 1, "1"), (2, 3, "5")).toDF("int", "int2", "str")
val limit = 1310721
val innerJoin = df.limit(limit).join(df2.limit(limit), Seq("int", "int2"), "inner")
.agg(count($"int"))
checkAnswer(innerJoin, Row(1) :: Nil)
}
}