[SPARK-17678][REPL][Branch-1.6] Honor spark.replClassServer.port in scala-2.11 repl #15253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #65944 has finished for PR 15253 at commit
|
Contributor
Author
|
@zsxwing , would you mind taking a look at this fix for 1.6 branch, thanks a lot. |
Member
|
retest this please |
Member
|
LGTM pending tests |
Member
|
Merging to 1.6. Jenkins didn't use Scala 2.11 to build. I just checked this PR locally. |
asfgit
pushed a commit
that referenced
this pull request
Oct 13, 2016
…cala-2.11 repl ## What changes were proposed in this pull request? Spark 1.6 Scala-2.11 repl doesn't honor "spark.replClassServer.port" configuration, so user cannot set a fixed port number through "spark.replClassServer.port". ## How was this patch tested? N/A Author: jerryshao <[email protected]> Closes #15253 from jerryshao/SPARK-17678.
Member
|
@jerryshao It's merged. Could you close this PR, please? |
Contributor
Author
|
Sure, thanks. |
|
Test build #66917 has finished for PR 15253 at commit
|
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Oct 14, 2016
…cala-2.11 repl ## What changes were proposed in this pull request? Spark 1.6 Scala-2.11 repl doesn't honor "spark.replClassServer.port" configuration, so user cannot set a fixed port number through "spark.replClassServer.port". ## How was this patch tested? N/A Author: jerryshao <[email protected]> Closes apache#15253 from jerryshao/SPARK-17678. (cherry picked from commit 18b173c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Spark 1.6 Scala-2.11 repl doesn't honor "spark.replClassServer.port" configuration, so user cannot set a fixed port number through "spark.replClassServer.port".
How was this patch tested?
N/A