Skip to content

Conversation

@lins05
Copy link
Contributor

@lins05 lins05 commented Sep 25, 2016

What changes were proposed in this pull request?

A follow up for #14597 to update feature selection docs about ChiSqSelector.

How was this patch tested?

Generated html docs. It can be previewed at:

@lins05 lins05 changed the title [SPARK-17017][ML][MLLIB][ML][DOC] Updated the ml feature selection doc for ChiSqSelector [SPARK-17017][ML][MLLIB][ML][DOC] Updated the ml/mllib feature selection docs for ChiSqSelector Sep 25, 2016
@lins05 lins05 force-pushed the spark-17017-update-docs-for-chisq-selector-fpr branch from b272dee to 4a2cf5e Compare September 25, 2016 16:18
@srowen
Copy link
Member

srowen commented Sep 25, 2016

Please add this to #15214 with @yanboliang -- this is getting spread across too many places.

@lins05
Copy link
Contributor Author

lins05 commented Sep 25, 2016

Just found #15214 and #15212, I think this one need to wait until those are merged.

@SparkQA
Copy link

SparkQA commented Sep 25, 2016

Test build #65886 has finished for PR 15236 at commit 4a2cf5e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Sep 26, 2016

@lins05 OK, #15214 is merged. I don't think this can relate to #15212 because it's not necessarily going to be added. Is this doc change still correct/relevant?

@lins05
Copy link
Contributor Author

lins05 commented Sep 26, 2016

@srowen I saw there was a proposal to change setAlpha to setFpr in #15214, but it was not changed when the PR is merged. So I think this PR is up to upate.

@asfgit asfgit closed this in b2a7eed Sep 28, 2016
@srowen
Copy link
Member

srowen commented Sep 28, 2016

Merged to master

@lins05 lins05 deleted the spark-17017-update-docs-for-chisq-selector-fpr branch September 28, 2016 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants