[SPARK-17577][Core] Update SparkContext.addFile to make it work well on Windows [2.0 backport] #15217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #65827 has finished for PR 15217 at commit
|
Member
|
LGTM as discussed in the other PR. |
Member
|
LGTM, Merging into |
asfgit
pushed a commit
that referenced
this pull request
Sep 23, 2016
… it work well on Windows ## What changes were proposed in this pull request? Update ```SparkContext.addFile``` to correct the use of ```URI``` and ```Path```, then it can work well on Windows. This is used for branch-2.0 backport, more details at #15131. ## How was this patch tested? Backport, checked by appveyor. Author: Yanbo Liang <[email protected]> Closes #15217 from yanboliang/uri-2.0.
Member
|
@yanboliang Would you close this PR by yourself? This PR may be closed automatically on merging. |
Contributor
Author
|
Close this PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update
SparkContext.addFileto correct the use ofURIandPath, then it can work well on Windows. This is used for branch-2.0 backport, more details at #15131.How was this patch tested?
Backport, checked by appveyor.