[SPARK-17418] Prevent kinesis-asl-assembly artifacts from being published #15167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanzin
approved these changes
Sep 20, 2016
| </plugin> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-install-plugin</artifactId> |
Contributor
There was a problem hiding this comment.
This might be ok? (It's supposed to be local only.) But probably good for consistency anyway.
Contributor
Author
There was a problem hiding this comment.
We need to do this in order to prevent this artifact from being published to a release staging repository, since the current release publishing scripts work by first installing the components to be published into a fresh temporary Maven repository and then searching that repository for artifacts, signing them, and uploading them to the staging repository using curl. See
spark/dev/create-release/release-build.sh
Line 294 in 7e418e9
|
Test build #65681 has finished for PR 15167 at commit
|
Member
|
Oh right, that's a nicer solution. LGTM. |
Contributor
Author
|
I'm going to merge this into master, branch-2.0, and branch-1.6. |
asfgit
pushed a commit
that referenced
this pull request
Sep 21, 2016
…shed This patch updates the `kinesis-asl-assembly` build to prevent that module from being published as part of Maven releases and snapshot builds. The `kinesis-asl-assembly` includes classes from the Kinesis Client Library (KCL) and Kinesis Producer Library (KPL), both of which are licensed under the Amazon Software License and are therefore prohibited from being distributed in Apache releases. Author: Josh Rosen <[email protected]> Closes #15167 from JoshRosen/stop-publishing-kinesis-assembly. (cherry picked from commit d7ee122) Signed-off-by: Josh Rosen <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Sep 21, 2016
…shed This patch updates the `kinesis-asl-assembly` build to prevent that module from being published as part of Maven releases and snapshot builds. The `kinesis-asl-assembly` includes classes from the Kinesis Client Library (KCL) and Kinesis Producer Library (KPL), both of which are licensed under the Amazon Software License and are therefore prohibited from being distributed in Apache releases. Author: Josh Rosen <[email protected]> Closes #15167 from JoshRosen/stop-publishing-kinesis-assembly.
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Sep 22, 2016
…shed This patch updates the `kinesis-asl-assembly` build to prevent that module from being published as part of Maven releases and snapshot builds. The `kinesis-asl-assembly` includes classes from the Kinesis Client Library (KCL) and Kinesis Producer Library (KPL), both of which are licensed under the Amazon Software License and are therefore prohibited from being distributed in Apache releases. Author: Josh Rosen <[email protected]> Closes apache#15167 from JoshRosen/stop-publishing-kinesis-assembly. (cherry picked from commit ce0a222)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the
kinesis-asl-assemblybuild to prevent that module from being published as part of Maven releases and snapshot builds.The
kinesis-asl-assemblyincludes classes from the Kinesis Client Library (KCL) and Kinesis Producer Library (KPL), both of which are licensed under the Amazon Software License and are therefore prohibited from being distributed in Apache releases.