Revert "[SPARK-17549][SQL] Only collect table size stat in driver for cached relation." #15157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @vanzin |
|
Test build #65624 has finished for PR 15157 at commit
|
Contributor
|
If it's not too much trouble, keeping the workaround in CodeGenerator.scala would be nice. Otherwise LGTM. |
Contributor
Author
|
Oh, right. Will do that. On Tue, Sep 20, 2016 at 8:57 AM -0700, "Marcelo Vanzin" [email protected] wrote: If it's not too much trouble, keeping the workaround in CodeGenerator.scala would be nice. Otherwise LGTM. — |
… cached relation." This reverts changes made to InMemoryRelation and InMemoryColumnarQuerySuite in commit 39e2bad. But, it keeps the change in CodeGenerator.scala to make recordCompilationStats tolerant to errors thrown by janino.
Contributor
Author
|
Done. |
Contributor
Author
|
I will merge this PR to master and branch 2.0 once it passes jenkins. |
|
Test build #65669 has finished for PR 15157 at commit
|
Contributor
Author
|
@vanzin I am merging this PR to master and branch 2.0 |
asfgit
pushed a commit
that referenced
this pull request
Sep 20, 2016
…for cached relation." This reverts commit 39e2bad because of the problem mentioned at https://issues.apache.org/jira/browse/SPARK-17549?focusedCommentId=15505060&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15505060 Author: Yin Huai <[email protected]> Closes #15157 from yhuai/revert-SPARK-17549. (cherry picked from commit 9ac68db) Signed-off-by: Yin Huai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 39e2bad because of the problem mentioned at https://issues.apache.org/jira/browse/SPARK-17549?focusedCommentId=15505060&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15505060