[SPARK-17551][SQL] Add DataFrame API for null ordering #15123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[SPARK-17551][SQL] complete the NULL ordering support in DataFrame APIs
Contributor
Author
|
This is based on #15107 but cleaned up a little bit. cc @hvanhovell and @xwu0226 |
petermaxlee
commented
Sep 17, 2016
| } | ||
|
|
||
| test("sorting with null ordering") { | ||
| val data = Seq[java.lang.Integer](2, 1, null).toDF("key") |
Contributor
Author
There was a problem hiding this comment.
This is a much simpler test case that the one added in #15107.
Contributor
There was a problem hiding this comment.
Thanks for the cleanup and refining the test case! For the test case with 2 column data, I was thinking to create a bit more complex ordering to utilize the prefix sort and regular GenerateOrdering in one query. But it is not necessary since the major PR for SQL interface has include such scenario.
|
Test build #65517 has finished for PR 15123 at commit
|
Contributor
Author
|
cc @hvanhovell |
Contributor
|
LGTM - merging to master. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pull request adds Scala/Java DataFrame API for null ordering (NULLS FIRST | LAST).
Also did some minor clean up for related code (e.g. incorrect indentation), and renamed "orderby-nulls-ordering.sql" to be consistent with existing test files.
How was this patch tested?
Added a new test case in DataFrameSuite.