Skip to content

SPARK-2662: Fix NPE for JsonProtocol #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

SPARK-2662: Fix NPE for JsonProtocol #1511

wants to merge 1 commit into from

Conversation

@witgo
Copy link
Contributor

@witgo witgo commented Jul 21, 2014

No description provided.

@SparkQA
Copy link

SparkQA commented Jul 21, 2014

QA tests have started for PR 1511. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16913/consoleFull

@SparkQA
Copy link

SparkQA commented Jul 21, 2014

QA results for PR 1511:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16913/consoleFull

@ScrapCodes
Copy link
Member

ScrapCodes commented Jul 23, 2014

it would be good, if you could describe when do you get this NPE ?

@mateiz
Copy link
Contributor

mateiz commented Jul 23, 2014

Jenkins, test this please

@mateiz
Copy link
Contributor

mateiz commented Jul 23, 2014

I think this can happen if you have a fetch-failed because the map output tracker deregistered a shuffle and didn't send you its info.

@SparkQA
Copy link

SparkQA commented Jul 23, 2014

QA tests have started for PR 1511. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17045/consoleFull

@SparkQA
Copy link

SparkQA commented Jul 23, 2014

QA results for PR 1511:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17045/consoleFull

@mateiz
Copy link
Contributor

mateiz commented Jul 23, 2014

Actually one more thing is missing, @witgo: can you open a JIRA issue for this and include it in the pull request's title? After that I'll merge it.

@witgo witgo changed the title Fix NPE for JsonProtocol SPARK-2662: Fix NPE for JsonProtocol Jul 24, 2014
@witgo
Copy link
Contributor Author

witgo commented Jul 24, 2014

@mateiz Done.

@mateiz
Copy link
Contributor

mateiz commented Jul 24, 2014

Alright, merged this. Thanks!

@asfgit asfgit closed this in 9e7725c Jul 24, 2014
@witgo witgo deleted the JsonProtocol branch July 24, 2014 05:53
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@witgo @conviva-zz
SPARK-2662: Fix NPE for JsonProtocol
5e310d9 
Author: GuoQiang Li <[email protected]>

Closes apache#1511 from witgo/JsonProtocol and squashes the following commits:

2b6227f [GuoQiang Li] Fix NPE for JsonProtocol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@witgo @SparkQA @ScrapCodes @mateiz