[SPARK-17531] Don't initialize Hive Listeners for the Execution Client #15086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @yhuai |
| assert(conf(ConfVars.METASTORE_EVENT_LISTENERS.varname) === "") | ||
| assert(conf(ConfVars.METASTORE_END_FUNCTION_LISTENERS.varname) === "") | ||
| } | ||
| } |
Contributor
|
LGTM pending jenkins. Once jenkins passes, I will merge this to master, branch 2.0, and branch 1.6. |
Contributor
Author
|
@yhuai This will not clearly merge into Spark 1.6 as these were in |
Contributor
|
Yea. That will be great! |
|
Test build #65331 has finished for PR 15086 at commit
|
Contributor
|
Thanks. Merging to master and branch 2.0. #15087 is the backport for branch 1.6. |
asfgit
pushed a commit
that referenced
this pull request
Sep 13, 2016
## What changes were proposed in this pull request? If a user provides listeners inside the Hive Conf, the configuration for these listeners are passed to the Hive Execution Client as well. This may cause issues for two reasons: 1. The Execution Client will actually generate garbage 2. The listener class needs to be both in the Spark Classpath and Hive Classpath This PR empties the listener configurations in `HiveUtils.newTemporaryConfiguration` so that the execution client will not contain the listener confs, but the metadata client will. ## How was this patch tested? Unit tests Author: Burak Yavuz <[email protected]> Closes #15086 from brkyvz/null-listeners. (cherry picked from commit 72edc7e) Signed-off-by: Yin Huai <[email protected]>
wgtmac
pushed a commit
to wgtmac/spark
that referenced
this pull request
Sep 19, 2016
## What changes were proposed in this pull request? If a user provides listeners inside the Hive Conf, the configuration for these listeners are passed to the Hive Execution Client as well. This may cause issues for two reasons: 1. The Execution Client will actually generate garbage 2. The listener class needs to be both in the Spark Classpath and Hive Classpath This PR empties the listener configurations in `HiveUtils.newTemporaryConfiguration` so that the execution client will not contain the listener confs, but the metadata client will. ## How was this patch tested? Unit tests Author: Burak Yavuz <[email protected]> Closes apache#15086 from brkyvz/null-listeners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If a user provides listeners inside the Hive Conf, the configuration for these listeners are passed to the Hive Execution Client as well. This may cause issues for two reasons:
This PR empties the listener configurations in
HiveUtils.newTemporaryConfigurationso that the execution client will not contain the listener confs, but the metadata client will.How was this patch tested?
Unit tests