Skip to content

Conversation

@junyangq
Copy link
Contributor

@junyangq junyangq commented Sep 2, 2016

What changes were proposed in this pull request?

This PR tries to add some more explanation to sparkR.session. It also modifies doc for count so when grouped in one doc, the description doesn't confuse users.

How was this patch tested?

Manual test.

screen shot 2016-09-02 at 1 21 36 pm

@SparkQA
Copy link

SparkQA commented Sep 2, 2016

Test build #64871 has finished for PR 14942 at commit 41db2cb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

shivaram commented Sep 2, 2016

cc @felixcheung

R/pkg/R/sparkR.R Outdated
#' Additional Spark properties can be set (...), and these named parameters take priority over
#' over values in master, appName, named lists of sparkConfig.
#' SparkSession is the entry point into SparkR. \code{sparkR.session} gets the existing
#' SparkSession or initialize a new SparkSession.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initializes

@felixcheung
Copy link
Member

felixcheung commented Sep 2, 2016

LGTM (except for one minor point)

@SparkQA
Copy link

SparkQA commented Sep 3, 2016

Test build #64885 has finished for PR 14942 at commit d2f1b6e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

shivaram commented Sep 3, 2016

Thanks - Merging this into master, branch-2.0

asfgit pushed a commit that referenced this pull request Sep 3, 2016
## What changes were proposed in this pull request?

This PR tries to add some more explanation to `sparkR.session`. It also modifies doc for `count` so when grouped in one doc, the description doesn't confuse users.

## How was this patch tested?

Manual test.

![screen shot 2016-09-02 at 1 21 36 pm](https://cloud.githubusercontent.com/assets/15318264/18217198/409613ac-7110-11e6-8dae-cb0c8df557bf.png)

Author: Junyang Qian <[email protected]>

Closes #14942 from junyangq/fixSparkRSessionDoc.

(cherry picked from commit d2fde6b)
Signed-off-by: Shivaram Venkataraman <[email protected]>
@asfgit asfgit closed this in d2fde6b Sep 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants