[SPARK-16926] [SQL] Add unit test to compare table and partition column metadata. #14930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ok to test |
| test("SPARK-16926: number of table and partition columns match for new partitioned table") { | ||
| val view = "src" | ||
| withTempView(view) { | ||
| spark.range(1, 5).createOrReplaceTempView(view) |
Contributor
There was a problem hiding this comment.
nit: we should alway use createTempView in test, to make sure the view we created is what we want, rather than some existing view.
Contributor
Author
There was a problem hiding this comment.
My understanding is that createOrReplaceTempView should ensure the same thing because any existing view would be replaced. I'm I missing something?
Contributor
There was a problem hiding this comment.
oh sorry I read the code wrong...
Contributor
|
LGTM |
|
Test build #64822 has finished for PR 14930 at commit
|
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add unit test for changes made in PR #14515. It makes sure that a newly created table has the same number of columns in table and partition metadata. This test fails before the changes introduced in #14515.
How was this patch tested?
Run new unit test.