[SPARK-17318][Tests]Fix ReplSuite replicating blocks of object with class defined in repl again #14905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| |val timeout = 60000 // 60 seconds | ||
| |val start = System.currentTimeMillis | ||
| |while(sc.getExecutorStorageStatus.size != 3 && |
Member
Author
There was a problem hiding this comment.
3 = 1 driver + 2 executors
Member
Author
|
/cc @ericl |
|
Test build #64739 has finished for PR 14905 at commit
|
Contributor
|
Btw this is done in DistributedSuite using On Wed, Aug 31, 2016, 7:19 PM UCB AMPLab [email protected] wrote:
|
Member
Author
It's not a public API. So I cannot use it in the repl |
Contributor
|
Ah, too bad then. Lgtm |
Member
Author
|
Thanks! Merging to master and 2.0 |
asfgit
pushed a commit
that referenced
this pull request
Sep 1, 2016
…class defined in repl again ## What changes were proposed in this pull request? After digging into the logs, I noticed the failure is because in this test, it starts a local cluster with 2 executors. However, when SparkContext is created, executors may be still not up. When one of the executor is not up during running the job, the blocks won't be replicated. This PR just adds a wait loop before running the job to fix the flaky test. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes #14905 from zsxwing/SPARK-17318-2. (cherry picked from commit 21c0a4f) Signed-off-by: Shixiong Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
After digging into the logs, I noticed the failure is because in this test, it starts a local cluster with 2 executors. However, when SparkContext is created, executors may be still not up. When one of the executor is not up during running the job, the blocks won't be replicated.
This PR just adds a wait loop before running the job to fix the flaky test.
How was this patch tested?
Jenkins