Skip to content

Conversation

@junyangq
Copy link
Contributor

What changes were proposed in this pull request?

The usage in the original example is incorrect. This PR fixes it.

How was this patch tested?

Manual test.

@felixcheung
Copy link
Member

LGTM

@SparkQA
Copy link

SparkQA commented Aug 31, 2016

Test build #64734 has finished for PR 14903 at commit 693b3a4.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

@junyangq @felixcheung The test error is due to an unrelated issue caused when we upgraded testthat on Jenkins. I'm sending a fix for it now

@junyangq
Copy link
Contributor Author

@shivaram I see. Thanks for letting us know.

@shivaram
Copy link
Contributor

The fix is in #14904

@shivaram
Copy link
Contributor

shivaram commented Sep 1, 2016

Jenkins, retest this please

@SparkQA
Copy link

SparkQA commented Sep 1, 2016

Test build #64743 has finished for PR 14903 at commit 693b3a4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

shivaram commented Sep 1, 2016

Merging this into master and branch-2.0

asfgit pushed a commit that referenced this pull request Sep 1, 2016
## What changes were proposed in this pull request?

The usage in the original example is incorrect. This PR fixes it.

## How was this patch tested?

Manual test.

Author: Junyang Qian <[email protected]>

Closes #14903 from junyangq/SPARKR-FixWindowPartitionByDoc.

(cherry picked from commit d008638)
Signed-off-by: Shivaram Venkataraman <[email protected]>
@asfgit asfgit closed this in d008638 Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants