Skip to content

[SPARK-17347][SQL][Examples]Encoder in Dataset example has incorrect type #14901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[SPARK-17347][SQL][Examples]Encoder in Dataset example has incorrect type #14901

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4533dd0
improve the doc for "spark.memory.offHeap.size"
CodingCat Mar 7, 2016
59f6edf
fix
CodingCat Mar 7, 2016
31a0cd7
the alternative Encoder type shall be Encoder[Map[String, Any]]
CodingCat Aug 31, 2016
8ef776d
fix the compilation error
CodingCat Aug 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/src/main/scala/org/apache/spark/examples/sql/SparkSQLExample.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ object SparkSQLExample {
// No pre-defined encoders for Dataset[Map[K,V]], define explicitly
implicit val mapEncoder = org.apache.spark.sql.Encoders.kryo[Map[String, Any]]
// Primitive types and case classes can be also defined as
implicit val stringIntMapEncoder: Encoder[Map[String, Int]] = ExpressionEncoder()
// implicit val stringIntMapEncoder: Encoder[Map[String, Any]] = ExpressionEncoder()
Copy link
Member

@srowen srowen Sep 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This compiled before though, right? you're saying it's unnecessary because of the implicit in the line above? that seems fine but let's delete these 2 lines then.

Copy link
Contributor Author

@CodingCat CodingCat Sep 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am saying that the comments (L205) seem to indicate that, besides L204, the encoder can be defined as L206 as well. Actually, L206 has the incorrect type (you can find that by removing L204 and compile with the original L206)

so, I fixed the type and comment the line for successful compilation

Copy link
Member

@srowen srowen Sep 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, LGTM


// row.getValuesMap[T] retrieves multiple columns at once into a Map[String, T]
teenagersDF.map(teenager => teenager.getValuesMap[Any](List("name", "age"))).collect()
Expand Down