[SPARK-17338][SQL] add global temp view #14897

cloud-fan · 2016-08-31T14:49:29Z

What changes were proposed in this pull request?

Global temporary view is a cross-session temporary view, which means it's shared among all sessions. Its lifetime is the lifetime of the Spark application, i.e. it will be automatically dropped when the application terminates. It's tied to a system preserved database global_temp(configurable via SparkConf), and we must use the qualified name to refer a global temp view, e.g. SELECT * FROM global_temp.view1.

changes for SessionCatalog:

add a new field gloabalTempViews: GlobalTempViewManager, to access the shared global temp views, and the global temp db name.
createDatabase will fail if users wanna create global_temp, which is system preserved.
setCurrentDatabase will fail if users wanna set global_temp, which is system preserved.
add createGlobalTempView, which is used in CreateViewCommand to create global temp views.
add dropGlobalTempView, which is used in CatalogImpl to drop global temp view.
add alterTempViewDefinition, which is used in AlterViewAsCommand to update the view definition for local/global temp views.
renameTable/dropTable/isTemporaryTable/lookupRelation/getTempViewOrPermanentTableMetadata/refreshTable will handle global temp views.

changes for SQL commands:

CreateViewCommand/AlterViewAsCommand is updated to support global temp views
ShowTablesCommand outputs a new column database, which is used to distinguish global and local temp views.
other commands can also handle global temp views if they call SessionCatalog APIs which accepts global temp views, e.g. DropTableCommand, AlterTableRenameCommand, ShowColumnsCommand, etc.

changes for other public API

add a new method dropGlobalTempView in Catalog
Catalog.findTable can find global temp view
add a new method createGlobalTempView in Dataset

How was this patch tested?

new tests in SQLViewSuite

cloud-fan · 2016-08-31T14:49:55Z

cc @yhuai @liancheng @clockfly

dongjoon-hyun · 2016-08-31T15:18:13Z

sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala

Hi, @cloud-fan .

Then, is there no way to drop a global temporary view when there exists a local temporary view?

e.g. If I created the followings,

default.view1 (permanent view in default schema)

view1 (local temporary view).

And, suddenly, a global view is created by another session.
3. view1 (global temporary view)

In my session, is there any way to drop 3 (global view view1) without dropping 2 (my local view 2)?

Could you add DROP GLOBAL VIEW like CREATE GLOBAL TEMPORARY VIEW?

see document here: https://github.com/apache/spark/pull/14897/files#diff-cfec39cf8accabd227bd325f0a0a5f30R49

yea, there is no way to drop a global temp view if a temp view with same name exists. We can have some discussion about it.

Yes. Right. Up to now, all happens in the same session. So, temporary view is created after permanent view always. It works like STACK.

However, this is a global view made by other session. So, it does not work like STACK. Even in the same session, if we execute 'create temporary view' and 'create global view', we must delete the local temporary view first. So, it seems more serious to me.

If that is a design choice, never mind.
I think it's okay if this PR can provide DROP GLOBAL VIEW together.

I think it is a bit risky to provide user the ability to drop a global view implicitly.

I think all global view modification commands should be done explicitly, including create, drop, alter..

SparkQA · 2016-08-31T16:10:54Z

Test build #64719 has finished for PR 14897 at commit 2b97fba.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- class TempViewManager
- case class DropViewCommand(name: TableIdentifier, ifExists: Boolean) extends RunnableCommand

clockfly · 2016-09-01T22:14:45Z

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/TempViewManager.scala

Will the TempViewManager used by local views?

gatorsmile · 2016-09-01T22:26:02Z

Maybe we can create a few test cases for verifying the behaviors of global temporary views. Below is an example. We did it for current_database

spark/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala

Lines 1082 to 1112 in a117afa

    
           test("current_database with multiple sessions") { 
        
             sql("create database a") 
        
             sql("use a") 
        
             val s2 = newSession() 
        
             s2.sql("create database b") 
        
             s2.sql("use b") 
        
             assert(sql("select current_database()").first() === Row("a")) 
        
             assert(s2.sql("select current_database()").first() === Row("b")) 
        
             try { 
        
               sql("create table test_a(key INT, value STRING)") 
        
               s2.sql("create table test_b(key INT, value STRING)") 
        
               sql("select * from test_a") 
        
               intercept[AnalysisException] { 
        
                 sql("select * from test_b") 
        
               } 
        
               sql("select * from b.test_b") 
        
               s2.sql("select * from test_b") 
        
               intercept[AnalysisException] { 
        
                 s2.sql("select * from test_a") 
        
               } 
        
               s2.sql("select * from a.test_a") 
        
             } finally { 
        
               sql("DROP TABLE IF EXISTS test_a") 
        
               s2.sql("DROP TABLE IF EXISTS test_b") 
        
             } 
        
           }

clockfly · 2016-09-01T22:27:56Z

sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala

We may want separate command for alter global view.

It is not safe for a user to be able to alter a global view directly.

gatorsmile · 2016-09-01T22:54:48Z

How about another API refreshTable for global temporary views? We allow users to refresh it for local temporary views.

spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala

Lines 491 to 498 in f7c9ff5

    
           def refreshTable(name: TableIdentifier): Unit = { 
        
             // Go through temporary tables and invalidate them. 
        
             // If the database is defined, this is definitely not a temp table. 
        
             // If the database is not defined, there is a good chance this is a temp table. 
        
             if (name.database.isEmpty) { 
        
               tempTables.get(formatTableName(name.table)).foreach(_.refresh()) 
        
             } 
        
           }

gatorsmile · 2016-09-01T23:01:14Z

We might need an update on all the comments regarding the local temporary views in SessionCatalog. You can get them by searching the usage of tempTables.

A few external DDL/APIs might need an update too. For example, SHOW TABLES.

More test cases are required for each external change, especially the resolution ordering and accessibility issues.

gatorsmile · 2016-09-01T23:22:10Z

When comparing between permanent views and the global temporary views, I am trying to list the major differences:

the scope of permanent views is cross-application; the scope of global temp views is cross-session but only accessible in the same application.
the definition of permanent views is permanently recorded in the external catalog; the definition of global temp views is lost after the application stops.

Is my understanding right?

yhuai · 2016-09-01T23:24:34Z

@srinathshankar also want to review this?

srinathshankar · 2016-09-02T23:27:00Z

sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala

Not part of this patch, but why is it ok for an alter view to work on a table ?

SparkQA · 2016-09-20T15:58:53Z

Test build #65662 has finished for PR 14897 at commit df6f5e5.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- class GlobalTempViewManager

SparkQA · 2016-09-20T16:23:30Z

Test build #65665 has finished for PR 14897 at commit b532e98.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- class GlobalTempViewManager

SparkQA · 2016-09-20T17:30:24Z

Test build #65668 has finished for PR 14897 at commit c360dbc.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- class GlobalTempViewManager

clockfly · 2016-09-21T01:03:17Z

sql/hive/src/test/scala/org/apache/spark/sql/hive/ListTablesSuite.scala

Can we avoid renaming createLocalTempView?

clockfly · 2016-09-21T01:03:49Z

sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4

Maybe not needing LOCAL key word?

clockfly · 2016-09-21T02:51:25Z

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala

Is this too restrictive? If the user ask directly for GLOBAL_TEMP_VIEW_DATABASE, may be we should allow it?

Since the name is very specific "_global_temp", it is unlikly that it may conflict with user table's name.

clockfly · 2016-09-21T02:52:40Z

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala

Maybe change the name to "_global_temporary_views"

SparkQA · 2016-09-21T14:07:41Z

Test build #65717 has finished for PR 14897 at commit 2f05b08.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- class GlobalTempViewManager
- case class CreateTempViewUsing(

yhuai · 2016-10-06T20:04:35Z

python/pyspark/sql/catalog.py

+        Traceback (most recent call last):
+            ...
+        AnalysisException: ...
+        """


I think this bad case will end up in the python doc. Can we move this test to the tests.py file (it is fine to do it in a follow-up pr)?

I followed the method doc in dropTempView, is it bad?

It will be pretty confusing because this test case will appear in the python doc (and users will see an example that throws exceptions).

yhuai · 2016-10-06T20:40:38Z

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/GlobalTempViewManager.scala

+      true
+    } else {
+      false
+    }


What is reason that failing to rename has two behavior (when source does not exist, we return false. But, when destination already exists, we thrown an error)?

This behaviour comes from the previous temp view: If the source doesn't exist, try persisted table/view, if source exists but destination already exists, throw an error.

yhuai · 2016-10-06T22:35:15Z

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala

+    if (dbName == globalTempViewManager.database) {
+      throw new AnalysisException(
+        s"${globalTempViewManager.database} is a system preserved database, " +
+          "you cannot use it as current database.")


Seems it will be useful to let users know how to access temp views under this namespace.

yhuai · 2016-10-08T01:30:36Z

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala

+      if (db == globalTempViewManager.database) {
+        globalTempViewManager.get(table).map { viewDef =>
+          SubqueryAlias(relationAlias, viewDef, Some(name))
+        }.getOrElse(throw new NoSuchTableException(db, table))


In the else branch, we are just doing SubqueryAlias(relationAlias, tempTables(table), Option(name)). Later we should also make this branch and that branch consistent (by throwing NoSuchTableException).

We will never hit NoSuchTableException in the else branch, because we have !tempTables.contains(table) in the else if branch.

I don't like this style and prefer the new atomic way which is used for the global temp view, so that we don't need to wrap the whole method in synchronized block. But I wanna minimal the changes in this PR and leave this code unchanged. We can improve it in follow-ups.

yhuai · 2016-10-08T02:21:17Z

sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala

+   */
+  @throws[AnalysisException]
+  def createGlobalTempView(viewName: String): Unit = withPlan {
+    createTempViewCommand(viewName, replace = false, global = true)


What is the behavior of createTempView("a.b")?

yhuai · 2016-10-08T02:35:46Z

sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala


-  {
    // Set the Hive metastore warehouse path to the one we use
    val tempConf = new SQLConf


If this block does not use any val defined in this class, it is fine to move it.

yhuai · 2016-10-08T02:35:53Z

sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala


-  {
    // Set the Hive metastore warehouse path to the one we use
    val tempConf = new SQLConf


Can you double check?

yhuai · 2016-10-08T02:39:10Z

sql/core/src/test/scala/org/apache/spark/sql/execution/GlobalTempViewSuite.scala

+    checkAnswer(spark.table(s"$globalTempDB.src"), Row(1, "a"))
+
+    // Use qualified name to rename a global temp view.
+    sql(s"ALTER VIEW $globalTempDB.src RENAME TO src2")


Should we do sql(s"ALTER VIEW $globalTempDB.src RENAME TO $globalTempDB.src2") since we always require operating global temp views using qualified identifiers?

For ALTER VIEW/TABLE ... RENAME TO ..., we forbid users to specify database for the destination table name, because:

If the table/view belongs to a database, then it doesn't make sense to specify database for destination table name, because we can't change the database of the table/view by RENAME TO

if the table/view has no database(local temp view), then we can't specify database for destination table name.

Global temp view also follows these rules so we should not allow ALTER VIEW $globalTempDB.src RENAME TO $globalTempDB.src2

i see. Thanks for the explanation!

yhuai · 2016-10-08T02:39:53Z

sql/core/src/test/scala/org/apache/spark/sql/execution/GlobalTempViewSuite.scala

yhuai · 2016-10-08T02:40:50Z

sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala

+    val globalTempDB = sparkContext.conf.get(GLOBAL_TEMP_DATABASE).toLowerCase
+    if (externalCatalog.databaseExists(globalTempDB)) {
+      throw new SparkException(
+        s"$globalTempDB is a system preserved database, please rename your existing database " +


Should we also mention this conf?

In the offline discussion, we decided to hide this internal config to users, did I miss something?

oh no. I think it is fine to hide that conf. But, if the user hit this exception, seems it is better to let them know there is another workaround (renaming the existing db may not be easy).

SparkQA · 2016-10-09T12:00:06Z

Test build #66602 has finished for PR 14897 at commit aff5091.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2016-10-09T12:02:03Z

Test build #66603 has finished for PR 14897 at commit fb96f1c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

yhuai · 2016-10-10T02:38:23Z

LGTM. Let's make a small change according to #14897 (comment) and we can merge this pr. Thanks!

SparkQA · 2016-10-10T05:15:29Z

Test build #66620 has finished for PR 14897 at commit 29e292a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

cloud-fan · 2016-10-10T07:51:24Z

thanks for the review, merging to master!

rxin · 2016-10-10T18:30:39Z

sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala

+   * @param viewName the name of the view to be dropped.
+   * @since 2.1.0
+   */
+  def dropGlobalTempView(viewName: String): Boolean


need to explain the return type

rxin · 2016-10-10T18:31:09Z

sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala

   * @param viewName the name of the view to be dropped.
   * @since 2.0.0
   */
  def dropTempView(viewName: String): Unit


why is this returning unit when the global one return boolean? we should make them conssitent, i.e. this one should return boolean too.

also make sure we document the return value.

rxin · 2016-10-10T18:31:17Z

sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala

+   * preserved database `_global_temp`, and we must use the qualified name to refer a global temp
+   * view, e.g. `SELECT * FROM _global_temp.view1`.
+   *
+   * @throws TempTableAlreadyExistsException if the view name already exists


change this to AnalysisException

TempTableAlreadyExistsException is an internal exception

rxin · 2016-10-10T18:31:43Z

sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala

+      viewName: String,
+      replace: Boolean,
+      global: Boolean): CreateViewCommand = {
+    val viewType = if (global) {


shorten this to

val viewType = if (global) GlobalTempView else LocalTempView

rxin · 2016-10-10T18:46:04Z

@cloud-fan this looks good. I took a look at the API changes. Can you address the comments in a follow-up PR?

## What changes were proposed in this pull request? address post hoc review comments for #14897 ## How was this patch tested? N/A Author: Wenchen Fan <[email protected]> Closes #15424 from cloud-fan/global-temp-view.

## What changes were proposed in this pull request? SQLConf is session-scoped and mutable. However, we do have the requirement for a static SQL conf, which is global and immutable, e.g. the `schemaStringThreshold` in `HiveExternalCatalog`, the flag to enable/disable hive support, the global temp view database in #14897. Actually we've already implemented static SQL conf implicitly via `SparkConf`, this PR just make it explicit and expose it to users, so that they can see the config value via SQL command or `SparkSession.conf`, and forbid users to set/unset static SQL conf. ## How was this patch tested? new tests in SQLConfSuite Author: Wenchen Fan <[email protected]> Closes #15295 from cloud-fan/global-conf.

## What changes were proposed in this pull request? Global temporary view is a cross-session temporary view, which means it's shared among all sessions. Its lifetime is the lifetime of the Spark application, i.e. it will be automatically dropped when the application terminates. It's tied to a system preserved database `global_temp`(configurable via SparkConf), and we must use the qualified name to refer a global temp view, e.g. SELECT * FROM global_temp.view1. changes for `SessionCatalog`: 1. add a new field `gloabalTempViews: GlobalTempViewManager`, to access the shared global temp views, and the global temp db name. 2. `createDatabase` will fail if users wanna create `global_temp`, which is system preserved. 3. `setCurrentDatabase` will fail if users wanna set `global_temp`, which is system preserved. 4. add `createGlobalTempView`, which is used in `CreateViewCommand` to create global temp views. 5. add `dropGlobalTempView`, which is used in `CatalogImpl` to drop global temp view. 6. add `alterTempViewDefinition`, which is used in `AlterViewAsCommand` to update the view definition for local/global temp views. 7. `renameTable`/`dropTable`/`isTemporaryTable`/`lookupRelation`/`getTempViewOrPermanentTableMetadata`/`refreshTable` will handle global temp views. changes for SQL commands: 1. `CreateViewCommand`/`AlterViewAsCommand` is updated to support global temp views 2. `ShowTablesCommand` outputs a new column `database`, which is used to distinguish global and local temp views. 3. other commands can also handle global temp views if they call `SessionCatalog` APIs which accepts global temp views, e.g. `DropTableCommand`, `AlterTableRenameCommand`, `ShowColumnsCommand`, etc. changes for other public API 1. add a new method `dropGlobalTempView` in `Catalog` 2. `Catalog.findTable` can find global temp view 3. add a new method `createGlobalTempView` in `Dataset` ## How was this patch tested? new tests in `SQLViewSuite` Author: Wenchen Fan <[email protected]> Closes apache#14897 from cloud-fan/global-temp-view.

## What changes were proposed in this pull request? address post hoc review comments for apache#14897 ## How was this patch tested? N/A Author: Wenchen Fan <[email protected]> Closes apache#15424 from cloud-fan/global-temp-view.

## What changes were proposed in this pull request? SQLConf is session-scoped and mutable. However, we do have the requirement for a static SQL conf, which is global and immutable, e.g. the `schemaStringThreshold` in `HiveExternalCatalog`, the flag to enable/disable hive support, the global temp view database in apache#14897. Actually we've already implemented static SQL conf implicitly via `SparkConf`, this PR just make it explicit and expose it to users, so that they can see the config value via SQL command or `SparkSession.conf`, and forbid users to set/unset static SQL conf. ## How was this patch tested? new tests in SQLConfSuite Author: Wenchen Fan <[email protected]> Closes apache#15295 from cloud-fan/global-conf.

ChristopheSchmitz · 2017-03-07T14:28:53Z

Hi there,

I am a bit puzzled by the golbal_temp database. Why do we need to provide a qualified name to access the view? We can't even use the "USE global_temp" command. This breaks lots of tools that expect to switch to a db with the USE command.

Anyone know if there is a work around that issue? Any plan to write a patch?

Thanks
Christophe

cloud-fan · 2017-03-07T18:30:32Z

global_temp is a reserved, virtual database, and we don't include it in SHOW DATABASE, why do you wanna USE global_temp?

ChristopheSchmitz · 2017-03-07T21:29:00Z

Hi cloud-fan,
I am using global_temp because I have some view created with createGlobalTempView() that I would need to access using some tools for which I am configuring the database to use as "global_temp". As "USE global_temp" is failing, the tool fails.
I am using createGlobalTempView as I want to share the view across all sessions, as described in http://spark.apache.org/docs/2.1.0/sql-programming-guide.html#global-temporary-view
Any help would be greatly appreciated :)

cloud-fan · 2017-03-07T21:40:25Z

global temp view is designed to be accessed by fully qualified name, for some name conflicting concerns. I'm afraid you have to let your tool know this :)

ChristopheSchmitz · 2017-03-07T21:49:01Z

@cloud-fan thanks for pointing that out. Those closed-source tools might need some time to be updated. Nothing I can do on that front :(
As this fully qualified name constraints is just for preventing conflicts, do you see any issue if I clone the project, and remove the check that prevents from running "USE global_temp". Maybe the modification is more involved than that. What do you think?

cloud-fan · 2017-03-07T22:05:39Z

You can fork the project and remove the check, but then you need to check all the places that read current db, and think about what if the current db is global_temp, which may be a very tedious work...

dongjoon-hyun reviewed Aug 31, 2016
View reviewed changes

clockfly reviewed Sep 1, 2016
View reviewed changes

srinathshankar reviewed Sep 2, 2016
View reviewed changes

cloud-fan force-pushed the global-temp-view branch from 2b97fba to df6f5e5 Compare September 20, 2016 15:51

cloud-fan changed the title ~~[SPARK-17338][SQL] add global temp view~~ [SPARK-17338][SQL][WIP] add global temp view Sep 20, 2016

cloud-fan force-pushed the global-temp-view branch from df6f5e5 to b532e98 Compare September 20, 2016 16:13

cloud-fan force-pushed the global-temp-view branch from b532e98 to c360dbc Compare September 20, 2016 16:24

clockfly reviewed Sep 21, 2016

View reviewed changes

sql/hive/src/test/scala/org/apache/spark/sql/hive/ListTablesSuite.scala Outdated

Copy link

Contributor

clockfly Sep 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid renaming createLocalTempView?

clockfly reviewed Sep 21, 2016

View reviewed changes

sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 Outdated

Copy link

Contributor

clockfly Sep 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not needing LOCAL key word?

clockfly reviewed Sep 21, 2016

View reviewed changes

cloud-fan force-pushed the global-temp-view branch from c360dbc to 2f05b08 Compare September 21, 2016 13:49

cloud-fan changed the title ~~[SPARK-17338][SQL][WIP] add global temp view~~ [SPARK-17338][SQL] add global temp view Sep 21, 2016

implement global temp view

919e41a

yhuai requested changes Oct 8, 2016

View reviewed changes

cloud-fan added 2 commits October 9, 2016 17:12

Merge remote-tracking branch 'origin/master' into global-temp-view

96833d5

address comments from yhuai

fb96f1c

cloud-fan force-pushed the global-temp-view branch from aff5091 to fb96f1c Compare October 9, 2016 09:37

improve error message

29e292a

asfgit closed this in 23ddff4 Oct 10, 2016

srowen mentioned this pull request Oct 10, 2016

[HOT-FIX][SQL][TESTS] Remove unused function in SparkSqlParserSuite #15418

Closed

rxin reviewed Oct 10, 2016

View reviewed changes

cloud-fan mentioned this pull request Oct 11, 2016

[SPARK-17338][SQL][follow-up] add global temp view #15424

Closed

gatorsmile mentioned this pull request May 14, 2017

[SPARK-19236][Core] Added createOrReplaceGlobalTempView method #16598

Closed

[SPARK-17338][SQL] add global temp view #14897

[SPARK-17338][SQL] add global temp view #14897

Uh oh!

Conversation

cloud-fan commented Aug 31, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

How was this patch tested?

Uh oh!

cloud-fan commented Aug 31, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Aug 31, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gatorsmile commented Sep 1, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gatorsmile commented Sep 1, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gatorsmile commented Sep 1, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gatorsmile commented Sep 1, 2016

Uh oh!

yhuai commented Sep 1, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Sep 20, 2016

Uh oh!

SparkQA commented Sep 20, 2016

Uh oh!

SparkQA commented Sep 20, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Sep 21, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yhuai Oct 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

cloud-fan commented Aug 31, 2016 •

edited

Loading

gatorsmile commented Sep 1, 2016 •

edited

Loading

gatorsmile commented Sep 1, 2016 •

edited

Loading

yhuai Oct 8, 2016 •

edited

Loading

yhuai Oct 8, 2016 •

edited

Loading