-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-16283][SQL] Implements percentile_approx aggregation function which supports partial aggregation. #14868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,321 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.catalyst.expressions.aggregate | ||
|
|
||
| import java.nio.ByteBuffer | ||
|
|
||
| import com.google.common.primitives.{Doubles, Ints, Longs} | ||
|
|
||
| import org.apache.spark.sql.AnalysisException | ||
| import org.apache.spark.sql.catalyst.{InternalRow} | ||
| import org.apache.spark.sql.catalyst.analysis.TypeCheckResult | ||
| import org.apache.spark.sql.catalyst.analysis.TypeCheckResult.{TypeCheckFailure, TypeCheckSuccess} | ||
| import org.apache.spark.sql.catalyst.expressions._ | ||
| import org.apache.spark.sql.catalyst.expressions.aggregate.ApproximatePercentile.{PercentileDigest} | ||
| import org.apache.spark.sql.catalyst.util.{ArrayData, GenericArrayData} | ||
| import org.apache.spark.sql.catalyst.util.QuantileSummaries | ||
| import org.apache.spark.sql.catalyst.util.QuantileSummaries.{defaultCompressThreshold, Stats} | ||
| import org.apache.spark.sql.types._ | ||
|
|
||
| /** | ||
| * The ApproximatePercentile function returns the approximate percentile(s) of a column at the given | ||
| * percentage(s). A percentile is a watermark value below which a given percentage of the column | ||
| * values fall. For example, the percentile of column `col` at percentage 50% is the median of | ||
| * column `col`. | ||
| * | ||
| * This function supports partial aggregation. | ||
| * | ||
| * @param child child expression that can produce column value with `child.eval(inputRow)` | ||
| * @param percentageExpression Expression that represents a single percentage value or | ||
| * an array of percentage values. Each percentage value must be between | ||
| * 0.0 and 1.0. | ||
| * @param accuracyExpression Integer literal expression of approximation accuracy. Higher value | ||
| * yields better accuracy, the default value is | ||
| * DEFAULT_PERCENTILE_ACCURACY. | ||
| */ | ||
| @ExpressionDescription( | ||
| usage = | ||
| """ | ||
| _FUNC_(col, percentage [, accuracy]) - Returns the approximate percentile value of numeric | ||
| column `col` at the given percentage. The value of percentage must be between 0.0 | ||
| and 1.0. The `accuracy` parameter (default: 10000) is a positive integer literal which | ||
| controls approximation accuracy at the cost of memory. Higher value of `accuracy` yields | ||
| better accuracy, `1.0/accuracy` is the relative error of the approximation. | ||
|
|
||
| _FUNC_(col, array(percentage1 [, percentage2]...) [, accuracy]) - Returns the approximate | ||
| percentile array of column `col` at the given percentage array. Each value of the | ||
| percentage array must be between 0.0 and 1.0. The `accuracy` parameter (default: 10000) is | ||
| a positive integer literal which controls approximation accuracy at the cost of memory. | ||
| Higher value of `accuracy` yields better accuracy, `1.0/accuracy` is the relative error of | ||
| the approximation. | ||
| """) | ||
| case class ApproximatePercentile( | ||
| child: Expression, | ||
| percentageExpression: Expression, | ||
| accuracyExpression: Expression, | ||
| override val mutableAggBufferOffset: Int, | ||
| override val inputAggBufferOffset: Int) extends TypedImperativeAggregate[PercentileDigest] { | ||
|
|
||
| def this(child: Expression, percentageExpression: Expression, accuracyExpression: Expression) = { | ||
| this(child, percentageExpression, accuracyExpression, 0, 0) | ||
| } | ||
|
|
||
| def this(child: Expression, percentageExpression: Expression) = { | ||
| this(child, percentageExpression, Literal(ApproximatePercentile.DEFAULT_PERCENTILE_ACCURACY)) | ||
| } | ||
|
|
||
| // Mark as lazy so that accuracyExpression is not evaluated during tree transformation. | ||
| private lazy val accuracy: Int = accuracyExpression.eval().asInstanceOf[Int] | ||
|
|
||
| override def inputTypes: Seq[AbstractDataType] = { | ||
| Seq(DoubleType, TypeCollection(DoubleType, ArrayType), IntegerType) | ||
| } | ||
|
|
||
| // Mark as lazy so that percentageExpression is not evaluated during tree transformation. | ||
| private lazy val (returnPercentileArray: Boolean, percentages: Array[Double]) = { | ||
| (percentageExpression.dataType, percentageExpression.eval()) match { | ||
| // Rule ImplicitTypeCasts can cast other numeric types to double | ||
| case (_, num: Double) => (false, Array(num)) | ||
| case (ArrayType(baseType: NumericType, _), arrayData: ArrayData) => | ||
| val numericArray = arrayData.toObjectArray(baseType) | ||
| (true, numericArray.map { x => | ||
| baseType.numeric.toDouble(x.asInstanceOf[baseType.InternalType]) | ||
| }) | ||
| case other => | ||
| throw new AnalysisException(s"Invalid data type ${other._1} for parameter percentage") | ||
| } | ||
| } | ||
|
|
||
| override def checkInputDataTypes(): TypeCheckResult = { | ||
| val defaultCheck = super.checkInputDataTypes() | ||
| if (defaultCheck.isFailure) { | ||
| defaultCheck | ||
| } else if (!percentageExpression.foldable || !accuracyExpression.foldable) { | ||
| TypeCheckFailure(s"The accuracy or percentage provided must be a constant literal") | ||
| } else if (accuracy <= 0) { | ||
| TypeCheckFailure( | ||
| s"The accuracy provided must be a positive integer literal (current value = $accuracy)") | ||
| } else if (percentages.exists(percentage => percentage < 0.0D || percentage > 1.0D)) { | ||
| TypeCheckFailure( | ||
| s"All percentage values must be between 0.0 and 1.0 " + | ||
| s"(current = ${percentages.mkString(", ")})") | ||
| } else { | ||
| TypeCheckSuccess | ||
| } | ||
| } | ||
|
|
||
| override def createAggregationBuffer(): PercentileDigest = { | ||
| val relativeError = 1.0D / accuracy | ||
| new PercentileDigest(relativeError) | ||
| } | ||
|
|
||
| override def update(buffer: PercentileDigest, inputRow: InternalRow): Unit = { | ||
| val value = child.eval(inputRow) | ||
| // Ignore empty rows, for example: percentile_approx(null) | ||
| if (value != null) { | ||
| buffer.add(value.asInstanceOf[Double]) | ||
| } | ||
| } | ||
|
|
||
| override def merge(buffer: PercentileDigest, other: PercentileDigest): Unit = { | ||
| buffer.merge(other) | ||
| } | ||
|
|
||
| override def eval(buffer: PercentileDigest): Any = { | ||
| val result = buffer.getPercentiles(percentages) | ||
| if (result.length == 0) { | ||
| null | ||
| } else if (returnPercentileArray) { | ||
| new GenericArrayData(result) | ||
| } else { | ||
| result(0) | ||
| } | ||
| } | ||
|
|
||
| override def withNewMutableAggBufferOffset(newOffset: Int): ApproximatePercentile = | ||
| copy(mutableAggBufferOffset = newOffset) | ||
|
|
||
| override def withNewInputAggBufferOffset(newOffset: Int): ApproximatePercentile = | ||
| copy(inputAggBufferOffset = newOffset) | ||
|
|
||
| override def children: Seq[Expression] = Seq(child, percentageExpression, accuracyExpression) | ||
|
|
||
| // Returns null for empty inputs | ||
| override def nullable: Boolean = true | ||
|
|
||
| override def dataType: DataType = { | ||
| if (returnPercentileArray) ArrayType(DoubleType) else DoubleType | ||
| } | ||
|
|
||
| override def prettyName: String = "percentile_approx" | ||
|
|
||
| override def serialize(obj: PercentileDigest): Array[Byte] = { | ||
| ApproximatePercentile.serializer.serialize(obj) | ||
| } | ||
|
|
||
| override def deserialize(bytes: Array[Byte]): PercentileDigest = { | ||
| ApproximatePercentile.serializer.deserialize(bytes) | ||
| } | ||
| } | ||
|
|
||
| object ApproximatePercentile { | ||
|
|
||
| // Default accuracy of Percentile approximation. Larger value means better accuracy. | ||
| // The default relative error can be deduced by defaultError = 1.0 / DEFAULT_PERCENTILE_ACCURACY | ||
| val DEFAULT_PERCENTILE_ACCURACY: Int = 10000 | ||
|
|
||
| /** | ||
| * PercentileDigest is a probabilistic data structure used for approximating percentiles | ||
| * with limited memory. PercentileDigest is backed by [[QuantileSummaries]]. | ||
| * | ||
| * @param summaries underlying probabilistic data structure [[QuantileSummaries]]. | ||
| * @param isCompressed An internal flag from class [[QuantileSummaries]] to indicate whether the | ||
| * underlying quantileSummaries is compressed. | ||
| */ | ||
| class PercentileDigest( | ||
| private var summaries: QuantileSummaries, | ||
| private var isCompressed: Boolean) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why we need this flag?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
|
||
| // Trigger compression if the QuantileSummaries's buffer length exceeds | ||
| // compressThresHoldBufferLength. The buffer length can be get by | ||
| // quantileSummaries.sampled.length | ||
| private[this] final val compressThresHoldBufferLength: Int = { | ||
| // Max buffer length after compression. | ||
| val maxBufferLengthAfterCompression: Int = (1 / summaries.relativeError).toInt * 2 | ||
| // A safe upper bound for buffer length before compression | ||
| maxBufferLengthAfterCompression * 2 | ||
| } | ||
|
|
||
| def this(relativeError: Double) = { | ||
| this(new QuantileSummaries(defaultCompressThreshold, relativeError), isCompressed = true) | ||
| } | ||
|
|
||
| /** Returns compressed object of [[QuantileSummaries]] */ | ||
| def quantileSummaries: QuantileSummaries = { | ||
| if (!isCompressed) compress() | ||
| summaries | ||
| } | ||
|
|
||
| /** Insert an observation value into the PercentileDigest data structure. */ | ||
| def add(value: Double): Unit = { | ||
| summaries = summaries.insert(value) | ||
| // The result of QuantileSummaries.insert is un-compressed | ||
| isCompressed = false | ||
|
|
||
| // Currently, QuantileSummaries ignores the construction parameter compressThresHold, | ||
| // which may cause QuantileSummaries to occupy unbounded memory. We have to hack around here | ||
| // to make sure QuantileSummaries doesn't occupy infinite memory. | ||
| // TODO: Figure out why QuantileSummaries ignores construction parameter compressThresHold | ||
| if (summaries.sampled.length >= compressThresHoldBufferLength) compress() | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is surprising to see QuantileSummaries doesn't do automatic compression. Need to check with @thunterdb |
||
| } | ||
|
|
||
| /** In-place merges in another PercentileDigest. */ | ||
| def merge(other: PercentileDigest): Unit = { | ||
| if (!isCompressed) compress() | ||
| summaries = summaries.merge(other.quantileSummaries) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. other.quantileSummaries will get a compression version of QuantileSummaries. |
||
| } | ||
|
|
||
| /** | ||
| * Returns the approximate percentiles of all observation values at the given percentages. | ||
| * A percentile is a watermark value below which a given percentage of observation values fall. | ||
| * For example, the following code returns the 25th, median, and 75th percentiles of | ||
| * all observation values: | ||
| * | ||
| * {{{ | ||
| * val Array(p25, median, p75) = percentileDigest.getPercentiles(Array(0.25, 0.5, 0.75)) | ||
| * }}} | ||
| */ | ||
| def getPercentiles(percentages: Array[Double]): Array[Double] = { | ||
| if (!isCompressed) compress() | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is it possible to evaluate a uncompressed QuantileSummaries? Or it will be bad if we use percentile_approx as window function.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is not supported by QuantileSummaries to evaluate an uncompressed QuantileSummaries |
||
| if (summaries.count == 0 || percentages.length == 0) { | ||
| Array.empty[Double] | ||
| } else { | ||
| val result = new Array[Double](percentages.length) | ||
| var i = 0 | ||
| while (i < percentages.length) { | ||
| result(i) = summaries.query(percentages(i)) | ||
| i += 1 | ||
| } | ||
| result | ||
| } | ||
| } | ||
|
|
||
| private final def compress(): Unit = { | ||
| summaries = summaries.compress() | ||
| isCompressed = true | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Serializer for class [[PercentileDigest]] | ||
| * | ||
| * This class is thread safe. | ||
| */ | ||
| class PercentileDigestSerializer { | ||
|
|
||
| private final def length(summaries: QuantileSummaries): Int = { | ||
| // summaries.compressThreshold, summary.relativeError, summary.count | ||
| Ints.BYTES + Doubles.BYTES + Longs.BYTES + | ||
| // length of summary.sampled | ||
| Ints.BYTES + | ||
| // summary.sampled, Array[Stat(value: Double, g: Int, delta: Int)] | ||
| summaries.sampled.length * (Doubles.BYTES + Ints.BYTES + Ints.BYTES) | ||
| } | ||
|
|
||
| final def serialize(obj: PercentileDigest): Array[Byte] = { | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I swap the serialization implementation from ExpressionEncoder because it is not safe to initialize ExpressionEncoder at the Executor side. stacktrace: |
||
| val summary = obj.quantileSummaries | ||
| val buffer = ByteBuffer.wrap(new Array(length(summary))) | ||
| buffer.putInt(summary.compressThreshold) | ||
| buffer.putDouble(summary.relativeError) | ||
| buffer.putLong(summary.count) | ||
| buffer.putInt(summary.sampled.length) | ||
|
|
||
| var i = 0 | ||
| while (i < summary.sampled.length) { | ||
| val stat = summary.sampled(i) | ||
| buffer.putDouble(stat.value) | ||
| buffer.putInt(stat.g) | ||
| buffer.putInt(stat.delta) | ||
| i += 1 | ||
| } | ||
| buffer.array() | ||
| } | ||
|
|
||
| final def deserialize(bytes: Array[Byte]): PercentileDigest = { | ||
| val buffer = ByteBuffer.wrap(bytes) | ||
| val compressThreshold = buffer.getInt() | ||
| val relativeError = buffer.getDouble() | ||
| val count = buffer.getLong() | ||
| val sampledLength = buffer.getInt() | ||
| val sampled = new Array[Stats](sampledLength) | ||
|
|
||
| var i = 0 | ||
| while (i < sampledLength) { | ||
| val value = buffer.getDouble() | ||
| val g = buffer.getInt() | ||
| val delta = buffer.getInt() | ||
| sampled(i) = Stats(value, g, delta) | ||
| i += 1 | ||
| } | ||
| val summary = new QuantileSummaries(compressThreshold, relativeError, sampled, count) | ||
| new PercentileDigest(summary, isCompressed = true) | ||
| } | ||
| } | ||
|
|
||
| val serializer: PercentileDigestSerializer = new PercentileDigestSerializer | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not follow this style? https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/HyperLogLogPlusPlus.scala#L56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sql string is automatically generated, without hacking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And we can use the InputType Check facility to get a more consistent error message if check fails.