Skip to content

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Aug 27, 2016

What changes were proposed in this pull request?

As part of breaking Optimizer.scala apart, this patch moves various finish analysis optimization stage rules into a single file. I'm submitting separate pull requests so we can more easily merge this in branch-2.0 to simplify optimizer backports.

How was this patch tested?

This should be covered by existing tests.

@rxin
Copy link
Contributor Author

rxin commented Aug 27, 2016

cc @srinathshankar @cloud-fan



/**
* Finds all [[RuntimeReplaceable]] expressions and replace them with the expressions that can
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these rules are just straight copy without any modification

@SparkQA
Copy link

SparkQA commented Aug 27, 2016

Test build #64509 has finished for PR 14838 at commit 063ddfb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor

yhuai commented Aug 27, 2016

LGTM. Merging to master and branch 2.0.

@asfgit asfgit closed this in dcefac4 Aug 27, 2016
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64515/
Test FAILed.

asfgit pushed a commit that referenced this pull request Aug 27, 2016
…wn file

As part of breaking Optimizer.scala apart, this patch moves various finish analysis optimization stage rules into a single file. I'm submitting separate pull requests so we can more easily merge this in branch-2.0 to simplify optimizer backports.

This should be covered by existing tests.

Author: Reynold Xin <[email protected]>

Closes #14838 from rxin/SPARK-17269.

(cherry picked from commit dcefac4)
Signed-off-by: Reynold Xin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants