Skip to content

Conversation

@gatorsmile
Copy link
Member

@gatorsmile gatorsmile commented Aug 24, 2016

What changes were proposed in this pull request?

This PR is part of the original PR: #14625.

Based on file-based SQL end-to-end testing framework in SQLQueryTestSuite, this PR is to create test cases for outer joins.

In addition, this PR also renamed the test data sets to more meaningful names, based on the comments from @cloud-fan

How was this patch tested?

Using the same data and query, the Hive outputs are attached below:
hive.output.txt

After comparison, the Spark-generated results are the same.

.toDF("mapcol")
.createOrReplaceTempView("mapdata")

// A data set containing uppercase column names and column values
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need to add these tables here? can we just use temp views on the test cases?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will move them into the test cases.

@gatorsmile
Copy link
Member Author

gatorsmile commented Aug 24, 2016

Using the same data and query, the Hive outputs are attached below:
hive.output.txt

After comparison, the Spark-generated results are the same.

@SparkQA
Copy link

SparkQA commented Aug 24, 2016

Test build #64334 has finished for PR 14782 at commit dc36ce9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 24, 2016

Test build #64338 has finished for PR 14782 at commit 02d500b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Aug 25, 2016

@gatorsmile maybe you should stop porting more tests for now. I don't want you to waste time. I feel you are just porting the tests over from Hive compatibility suite, but that's not really the point. This is a framework to create test cases that would actually make sense. The best cases are the ones that are very small and simple and can test specific aspects of the query engine.

@gatorsmile
Copy link
Member Author

I see. Thanks! Let me close this one.

@gatorsmile gatorsmile closed this Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants