Skip to content

[SPARK-17166] [SQL] Store Table Properties in CTAS that is Converted to Data Source Tables #14727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-17166] [SQL] Store Table Properties in CTAS that is Converted to Data Source Tables #14727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1044,10 +1044,13 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder {
if (conf.convertCTAS && !hasStorageProperties) {
// At here, both rowStorage.serdeProperties and fileStorage.serdeProperties
// are empty Maps.
// For data source tables, table properties is only used to store schema and
// system-generated metadata. All user-specified properties/options will be stored
// in serde properties.
val optionsWithPath = if (location.isDefined) {
Map("path" -> location.get)
properties ++ Map("path" -> location.get)
} else {
Map.empty[String, String]
properties
}

val newTableDesc = tableDesc.copy(
Expand Down
14 changes: 14 additions & 0 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,20 @@ class HiveDDLSuite
}
}

test("CTAS - converted to Data Source Table but lost table properties") {
withSQLConf(SQLConf.CONVERT_CTAS.key -> "true") {
withTable("t") {
sql("CREATE TABLE t TBLPROPERTIES('prop1' = 'c', 'prop2' = 'd') AS SELECT 1 as a, 1 as b")
val tableDesc = spark.sessionState.catalog.getTableMetadata(TableIdentifier("t"))
assert(tableDesc.properties.get("prop1").isEmpty)
assert(tableDesc.properties.get("prop2").isEmpty)
assert(tableDesc.storage.properties.get("prop1") == Option("c"))
assert(tableDesc.storage.properties.get("prop2") == Option("d"))
Copy link
Contributor

@cloud-fan cloud-fan Aug 20, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this what we want? Why do the table properties in Hive serde table should go to storage properties in data source table?

Ideally data source table should have data source options(storage properties) and table properties. Currently we don't support specifying table properties for data source tables, but it doesn't mean we will never do it. I think we can do it when unify the CREATE TABLE syntax.

Copy link
Member Author

@gatorsmile gatorsmile Aug 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh, agree! Let me close this PR. Thanks!

checkAnswer(spark.table("t"), Row(1, 1) :: Nil)
}
}
}

test("desc table for data source table - partitioned bucketed table") {
withTable("t1") {
spark
Expand Down