SPARK-12868: Allow Add jar to add jars from hdfs/s3n urls. #14720
Conversation
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Why do you need {}?
Parth-Brahmbhatt
force-pushed
the
SPARK-12868
branch
from
66dfb69 to
078f05a
Compare
|
Can one of the committers take a look at this PR? |
1 similar comment
|
Can one of the committers take a look at this PR? |
|
Request for review one more time. |
|
Ping. |
|
Request for review. |
|
@srowen would this make sense to you? |
| val testJar = "hdfs://nn:8020/foo.jar" | ||
| // This should fail with unknown host, as its just testing the URL parsing | ||
| // before SPARK-12868 it was failing with Malformed URI | ||
| val e = intercept[RuntimeException] { |
There was a problem hiding this comment.
I think this test should be improved before merging this. Looking for a RuntimeException to validate that the Jar was registered is brittle and can easily pass when the registration doesn't actually work.
|
Hi @Parth-Brahmbhatt, is it still active? If so is there any argument against #14720 (comment)? |
|
It has been fixed by #17342. |
|
I will propose to close this after a week if it is still inactive or no objection to ^. |
|
closing. |
7 participants
What changes were proposed in this pull request?
Add jar command fails when given s3n or hdfs urls. This changes fixes that.
How was this patch tested?
unit test added, it was just copied from a previously opened PR #10797 so credit should be given to the person who originally posted the patch.