[SPARK-17106][SQL] Simplify the SubqueryExpression interface #14685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
Contributor
Author
|
|
||
| override def semanticEquals(other: Expression): Boolean = other match { | ||
| case s: ScalarSubquery => executedPlan.sameResult(executedPlan) | ||
| case s: ScalarSubquery => plan.sameResult(s.plan) |
Contributor
Author
There was a problem hiding this comment.
This fixes a small bug in sematicEquals.
|
Test build #63916 has finished for PR 14685 at commit
|
Contributor
|
LGTM, merging into master, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The current subquery expression interface contains a little bit of technical debt in the form of a few different access paths to get and set the query contained by the expression. This is confusing to anyone who goes over this code.
This PR unifies these access paths.
How was this patch tested?
(Existing tests)