[SPARK-17007][SQL] Move test data files into a test-data folder #14589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #63571 has finished for PR 14589 at commit
|
|
Test build #63573 has finished for PR 14589 at commit
|
Contributor
|
Thanks - merging in master. |
Member
|
Seems OK, but src/test/resources was already only a "test data" dir by nature. I don't think this helped anything. |
asfgit
pushed a commit
that referenced
this pull request
Aug 11, 2016
## What changes were proposed in this pull request? This patch moves all the test data files in sql/core/src/test/resources to sql/core/src/test/resources/test-data, so we don't clutter the top level sql/core/src/test/resources. Also deleted sql/core/src/test/resources/old-repeated.parquet since it is no longer used. The change will make it easier to spot sql-tests directory. ## How was this patch tested? This is a test-only change. Author: petermaxlee <[email protected]> Closes #14589 from petermaxlee/SPARK-17007. (cherry picked from commit 665e175) Signed-off-by: Wenchen Fan <[email protected]>
Contributor
|
backport to 2.0! |
Member
|
@cloud-fan why backport into a maintenance release? |
Contributor
|
@srowen there are bug fixes that are tested by this new harness (technically not super relevant to this pr though, but all those files are in the same resources directory). |
Member
|
I see. This is also why I would not have made this change. Can you leave these open for >= 1 day if it's not an emergency? last week I saw a JIRA + PR opened and closed in 2 hours. We should try not to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch moves all the test data files in sql/core/src/test/resources to sql/core/src/test/resources/test-data, so we don't clutter the top level sql/core/src/test/resources. Also deleted sql/core/src/test/resources/old-repeated.parquet since it is no longer used.
The change will make it easier to spot sql-tests directory.
How was this patch tested?
This is a test-only change.