Skip to content

Conversation

@rickalm
Copy link

@rickalm rickalm commented Aug 8, 2016

What changes were proposed in this pull request?

Changing the URI for Maven 3.3.3, version is no longer available on previous endpoint

How was this patch tested?

Successfully built spark using make_distribution after the patch was applied

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@holdenk
Copy link
Contributor

holdenk commented Aug 8, 2016

cc @srowen for build update

local MVN_VERSION="3.3.3"

install_app \
"https://www.apache.org/dyn/closer.lua?action=download&filename=/maven/maven-3/${MVN_VERSION}/binaries" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly enough 3.3.9 works through the URL but 3.3.3 doesn't appear to anymore - I'm not sure if maybe just one of the mirrors is screwed up or if this is a more intentional change.

@rickalm
Copy link
Author

rickalm commented Aug 8, 2016

Was considering withdrawing the PR. Here are my thoughts

Tag v1.6.2 specifies mvn 3.3.3 (unless user intentionally overrides). Users who previously built wanting to replicate their previous build have two choices:

1, Apply this patch allowing v1.6.2 to be build as previous
2, Apply PR #14066 bumping maven to 3.3.9 (btw this PR misses updating the pom.xml

The purist in me thinks 1 is the correct approach, but I'll defer to general wisdom

@srowen thoughts ?

@srowen
Copy link
Member

srowen commented Aug 8, 2016

This is already in branch-1.6: https://github.com/apache/spark/blob/branch-1.6/build/mvn
We can't change releases/tags of course. Yeah, this is because non-current versions eventually get moved off active mirrors. It's not great but only a problem if you don't actually have Maven installed. I'd expect most people have 3.3.x available locally anyway.

I think we don't want to download every time from dist, or that's discouraged.

@rickalm rickalm closed this Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants