Skip to content

Conversation

@srowen
Copy link
Member

@srowen srowen commented Aug 8, 2016

What changes were proposed in this pull request?

SparkContext.getOrCreate shouldn't warn about ignored config if

  • it wasn't ignored because a new context is created with it or
  • no config was actually provided

How was this patch tested?

Jenkins + existing tests.

… wasn't ignored because a new context is created with it or b) no config was actually provided
@SparkQA
Copy link

SparkQA commented Aug 8, 2016

Test build #63344 has finished for PR 14533 at commit 784f678.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@markhamstra
Copy link
Contributor

PR title typo? Intended "misleading"?

@srowen srowen changed the title [SPARK-16606] [CORE] isleading warning for SparkContext.getOrCreate "WARN SparkContext: Use an existing SparkContext, some configuration may not take effect." [SPARK-16606] [CORE] Misleading warning for SparkContext.getOrCreate "WARN SparkContext: Use an existing SparkContext, some configuration may not take effect." Aug 8, 2016
@jaceklaskowski
Copy link
Contributor

LGTM

@srowen
Copy link
Member Author

srowen commented Aug 9, 2016

Merged to master

@asfgit asfgit closed this in 801e4d0 Aug 9, 2016
@srowen srowen deleted the SPARK-16606 branch August 9, 2016 08:41
asfgit pushed a commit that referenced this pull request Oct 22, 2016
… the same log message typo

## What changes were proposed in this pull request?

Tiny follow-up to SPARK-16606 / #14533 , to correct more instances of the same log message typo

## How was this patch tested?

Existing tests (no functional change anyway)

Author: Sean Owen <[email protected]>

Closes #15586 from srowen/SPARK-16606.2.

(cherry picked from commit 7178c56)
Signed-off-by: Reynold Xin <[email protected]>
asfgit pushed a commit that referenced this pull request Oct 22, 2016
… the same log message typo

## What changes were proposed in this pull request?

Tiny follow-up to SPARK-16606 / #14533 , to correct more instances of the same log message typo

## How was this patch tested?

Existing tests (no functional change anyway)

Author: Sean Owen <[email protected]>

Closes #15586 from srowen/SPARK-16606.2.
robert3005 pushed a commit to palantir/spark that referenced this pull request Nov 1, 2016
… the same log message typo

## What changes were proposed in this pull request?

Tiny follow-up to SPARK-16606 / apache#14533 , to correct more instances of the same log message typo

## How was this patch tested?

Existing tests (no functional change anyway)

Author: Sean Owen <[email protected]>

Closes apache#15586 from srowen/SPARK-16606.2.
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
… the same log message typo

## What changes were proposed in this pull request?

Tiny follow-up to SPARK-16606 / apache#14533 , to correct more instances of the same log message typo

## How was this patch tested?

Existing tests (no functional change anyway)

Author: Sean Owen <[email protected]>

Closes apache#15586 from srowen/SPARK-16606.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants