Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

This PR fixes the following to make checkAnswer raise TestFailedException again instead of java.util.NoSuchElementException: key not found: TZ in the environments without TZ variable. Also, this PR adds QueryTestSuite class for testing QueryTest itself.

- |Timezone Env: ${sys.env("TZ")}
+ |Timezone Env: ${sys.env.getOrElse("TZ", "")}

How was this patch tested?

Pass the Jenkins tests with a new test suite.

@SparkQA
Copy link

SparkQA commented Aug 8, 2016

Test build #63332 has finished for PR 14528 at commit 9c4f02b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class QueryTestSuite extends QueryTest with test.SharedSQLContext

@dongjoon-hyun
Copy link
Member Author

Hi, @rxin .
Could you review this PR please?

@srowen
Copy link
Member

srowen commented Aug 8, 2016

LGTM

@dongjoon-hyun
Copy link
Member Author

Oh, thank you, @srowen !

@srowen
Copy link
Member

srowen commented Aug 9, 2016

Merged to master

@asfgit asfgit closed this in 2154345 Aug 9, 2016
@dongjoon-hyun
Copy link
Member Author

Thank you, @srowen .

@dongjoon-hyun dongjoon-hyun deleted the SPARK-16940 branch January 17, 2018 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants