[SPARK-16936] [SQL] Case Sensitivity Support for Refresh Temp Table #14523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #63319 has finished for PR 14523 at commit
|
Member
Author
|
cc @rxin @cloud-fan This is a simple fix. Could you review the fix? Thanks! |
|
|
||
| // Delete a file | ||
| deleteOneFileInDirectory(location) | ||
| intercept[SparkException] {sql("select count(*) from view_refresh").first()} |
Contributor
There was a problem hiding this comment.
nit: use intercept[..](...) for one line code.
Contributor
|
LGTM, is it a regression for 2.0? |
Member
Author
|
This is not a regression, but Spark 2.0 has the issue. Thanks! |
|
Test build #63340 has finished for PR 14523 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Aug 8, 2016
### What changes were proposed in this pull request? Currently, the `refreshTable` API is always case sensitive. When users use the view name without the exact case match, the API silently ignores the call. Users might expect the command has been successfully completed. However, when users run the subsequent SQL commands, they might still get the exception, like ``` Job aborted due to stage failure: Task 1 in stage 4.0 failed 1 times, most recent failure: Lost task 1.0 in stage 4.0 (TID 7, localhost): java.io.FileNotFoundException: File file:/private/var/folders/4b/sgmfldk15js406vk7lw5llzw0000gn/T/spark-bd4b9ea6-9aec-49c5-8f05-01cff426211e/part-r-00000-0c84b915-c032-4f2e-abf5-1d48fdbddf38.snappy.parquet does not exist ``` This PR is to fix the issue. ### How was this patch tested? Added a test case. Author: gatorsmile <[email protected]> Closes #14523 from gatorsmile/refreshTempTable. (cherry picked from commit 5959df2) Signed-off-by: Wenchen Fan <[email protected]>
Contributor
|
thanks, merging to master and 2.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, the
refreshTableAPI is always case sensitive.When users use the view name without the exact case match, the API silently ignores the call. Users might expect the command has been successfully completed. However, when users run the subsequent SQL commands, they might still get the exception, like
This PR is to fix the issue.
How was this patch tested?
Added a test case.