[SPARK-16749][SQL] Simplify processing logic in LEAD/LAG processing. #14376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @yhuai |
|
Test build #62916 has finished for PR 14376 at commit
|
| target, | ||
| ordinal, | ||
| functions, | ||
| functions.map(_.asInstanceOf[OffsetWindowFunction]), |
Contributor
There was a problem hiding this comment.
leave a comment here about why it is safe to blindly cast?
|
Test build #62967 has finished for PR 14376 at commit
|
| */ | ||
| private[execution] final class OffsetWindowFunctionFrame( | ||
| target: MutableRow, | ||
| ordinal: Int, |
Contributor
There was a problem hiding this comment.
Since we are changing this file, can you add comment to explain what is ordinal (with an example)?
Contributor
Author
There was a problem hiding this comment.
Done. In the class doc.
|
Test build #63381 has finished for PR 14376 at commit
|
Contributor
|
Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The logic for LEAD/LAG processing is more complex that it needs to be. This PR fixes that.
How was this patch tested?
Existing tests.