Skip to content

Conversation

@cloud-fan
Copy link
Contributor

What changes were proposed in this pull request?

after #12945, we renamed the registerTempTable to createTempView, as we do create a view actually. This PR renames SQLTestUtils.withTempTable to reflect this change.

How was this patch tested?

N/A

@cloud-fan
Copy link
Contributor Author

@gatorsmile
Copy link
Member

LGTM, pending jenkins

@SparkQA
Copy link

SparkQA commented Jul 22, 2016

Test build #62729 has finished for PR 14318 at commit 3a3d28b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor

yhuai commented Jul 22, 2016

Let's create a jira :)

@cloud-fan cloud-fan changed the title [TEST][minor] rename SQLTestUtils.withTempTable to withTempView [SPARK-16690][TEST] rename SQLTestUtils.withTempTable to withTempView Jul 23, 2016
@rxin
Copy link
Contributor

rxin commented Jul 23, 2016

Merging in master.

@asfgit asfgit closed this in 86c2752 Jul 23, 2016
@rxin
Copy link
Contributor

rxin commented Jul 23, 2016

I'm going to cherry pick this into branch-2.0 to avoid conflicts in bug fixes.

asfgit pushed a commit that referenced this pull request Jul 23, 2016
after #12945, we renamed the `registerTempTable` to `createTempView`, as we do create a view actually. This PR renames `SQLTestUtils.withTempTable` to reflect this change.

N/A

Author: Wenchen Fan <[email protected]>

Closes #14318 from cloud-fan/minor4.

(cherry picked from commit 86c2752)
Signed-off-by: Reynold Xin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants