[SPARK-16538][SPARKR] fix R call with namespace operator on SparkSession functions #14195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixcheung
changed the title
|
Test build #62296 has finished for PR 14195 at commit
|
Member
|
Hi, @felixcheung SparkR::sql("")I know that it's not necessary, but it's just because the JIRA/PR looks different at the first glance. |
Member
Author
|
Thanks. That actually would fail - can't run an empty sql query. |
Member
|
Yep. I mean . :) |
Member
|
What I wanted is |
Contributor
|
I guess it would be good to have an additional test case, but I'm going to merge this to make sure this makes 2.0 RCs. LGTM. We could look at ways to make this more robust in the future |
asfgit
pushed a commit
that referenced
this pull request
Jul 14, 2016
…ion functions ## What changes were proposed in this pull request? Fix function routing to work with and without namespace operator `SparkR::createDataFrame` ## How was this patch tested? manual, unit tests shivaram Author: Felix Cheung <[email protected]> Closes #14195 from felixcheung/rroutedefault. (cherry picked from commit 12005c8) Signed-off-by: Shivaram Venkataraman <[email protected]>
Member
|
Great. This is in 2.0! |
Member
Author
|
Adding more tests in new PR. I'm hoping to remove deprecated functions and this routing mechanism as soon as 2.0.0 is released... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix function routing to work with and without namespace operator
SparkR::createDataFrameHow was this patch tested?
manual, unit tests
@shivaram