Skip to content

Conversation

@felixcheung
Copy link
Member

What changes were proposed in this pull request?

Minor documentation update for code example, code style, and missed reference to "sparkR.init"

How was this patch tested?

manual

@shivaram

@SparkQA
Copy link

SparkQA commented Jul 13, 2016

Test build #62228 has finished for PR 14178 at commit 30c7c81.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

docs/sparkr.md Outdated

<div data-lang="r" markdown="1">
{% highlight r %}
df <- read.df(csvPath, "csv", header = "true", inferSchema = "true", na.string = "NA")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be na.strings (string -> strings)

@SparkQA
Copy link

SparkQA commented Jul 13, 2016

Test build #62280 has finished for PR 14178 at commit ab0af9f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

writeLines(mockLinesCsv, csvPath)

df2 <- read.df(csvPath, "csv", header = "true", inferSchema = "true", na.string = "Empty")
df2 <- read.df(csvPath, "csv", header = "true", inferSchema = "true", na.strings = "Empty")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm how was this test passing before ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah got it. Cool

@shivaram
Copy link
Contributor

LGTM. Merging this to master, branch-2.0

asfgit pushed a commit that referenced this pull request Jul 13, 2016
…example

## What changes were proposed in this pull request?

Minor documentation update for code example, code style, and missed reference to "sparkR.init"

## How was this patch tested?

manual

shivaram

Author: Felix Cheung <[email protected]>

Closes #14178 from felixcheung/rcsvprogrammingguide.

(cherry picked from commit fb2e8ee)
Signed-off-by: Shivaram Venkataraman <[email protected]>
@asfgit asfgit closed this in fb2e8ee Jul 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants