-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARKR][DOCS][MINOR] R programming guide to include csv data source example #14178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #62228 has finished for PR 14178 at commit
|
docs/sparkr.md
Outdated
|
|
||
| <div data-lang="r" markdown="1"> | ||
| {% highlight r %} | ||
| df <- read.df(csvPath, "csv", header = "true", inferSchema = "true", na.string = "NA") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be na.strings (string -> strings)
|
Test build #62280 has finished for PR 14178 at commit
|
| writeLines(mockLinesCsv, csvPath) | ||
|
|
||
| df2 <- read.df(csvPath, "csv", header = "true", inferSchema = "true", na.string = "Empty") | ||
| df2 <- read.df(csvPath, "csv", header = "true", inferSchema = "true", na.strings = "Empty") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm how was this test passing before ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah got it. Cool
|
LGTM. Merging this to master, branch-2.0 |
…example ## What changes were proposed in this pull request? Minor documentation update for code example, code style, and missed reference to "sparkR.init" ## How was this patch tested? manual shivaram Author: Felix Cheung <[email protected]> Closes #14178 from felixcheung/rcsvprogrammingguide. (cherry picked from commit fb2e8ee) Signed-off-by: Shivaram Venkataraman <[email protected]>
What changes were proposed in this pull request?
Minor documentation update for code example, code style, and missed reference to "sparkR.init"
How was this patch tested?
manual
@shivaram