-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-14812][ML][MLLIB][PYTHON] Experimental, DeveloperApi annotation audit for ML #14147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #62132 has finished for PR 14147 at commit
|
|
CC: @MLnick @yanboliang If you have a chance |
|
Test build #62184 has finished for PR 14147 at commit
|
|
Test build #62193 has finished for PR 14147 at commit
|
|
@jkbradley I'd like to leave |
|
@yanboliang Thanks for taking a look! I reverted the LDA changes for spark.ml. |
|
Test build #62266 has finished for PR 14147 at commit
|
|
Merging with master and branch-2.0 |
…n audit for ML ## What changes were proposed in this pull request? General decisions to follow, except where noted: * spark.mllib, pyspark.mllib: Remove all Experimental annotations. Leave DeveloperApi annotations alone. * spark.ml, pyspark.ml ** Annotate Estimator-Model pairs of classes and companion objects the same way. ** For all algorithms marked Experimental with Since tag <= 1.6, remove Experimental annotation. ** For all algorithms marked Experimental with Since tag = 2.0, leave Experimental annotation. * DeveloperApi annotations are left alone, except where noted. * No changes to which types are sealed. Exceptions where I am leaving items Experimental in spark.ml, pyspark.ml, mainly because the items are new: * Model Summary classes * MLWriter, MLReader, MLWritable, MLReadable * Evaluator and subclasses: There is discussion of changes around evaluating multiple metrics at once for efficiency. * RFormula: Its behavior may need to change slightly to match R in edge cases. * AFTSurvivalRegression * MultilayerPerceptronClassifier DeveloperApi changes: * ml.tree.Node, ml.tree.Split, and subclasses should no longer be DeveloperApi ## How was this patch tested? N/A Note to reviewers: * spark.ml.clustering.LDA underwent significant changes (additional methods), so let me know if you want me to leave it Experimental. * Be careful to check for cases where a class should no longer be Experimental but has an Experimental method, val, or other feature. I did not find such cases, but please verify. Author: Joseph K. Bradley <[email protected]> Closes #14147 from jkbradley/experimental-audit. (cherry picked from commit 01f09b1) Signed-off-by: Joseph K. Bradley <[email protected]>
What changes were proposed in this pull request?
General decisions to follow, except where noted:
** Annotate Estimator-Model pairs of classes and companion objects the same way.
** For all algorithms marked Experimental with Since tag <= 1.6, remove Experimental annotation.
** For all algorithms marked Experimental with Since tag = 2.0, leave Experimental annotation.
Exceptions where I am leaving items Experimental in spark.ml, pyspark.ml, mainly because the items are new:
DeveloperApi changes:
How was this patch tested?
N/A
Note to reviewers: