[SPARK-16439] Fix number formatting in SQL UI #14142
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM. Actually all other instances of NumberFormat in the project omit grouping separators, for various reasons. |
Contributor
Author
|
Can we test this ? |
Member
|
Jenkins add to whitelist |
Member
|
Jenkins test this please |
|
Test build #62163 has finished for PR 14142 at commit
|
Contributor
Author
|
Merging ? |
Member
|
Yes, no need to ping inside of a day or two. We will often leave it open at least that long in case anyone has comments. |
Member
|
merged to master/2.0 |
asfgit
pushed a commit
that referenced
this pull request
Jul 13, 2016
## What changes were proposed in this pull request? Spark SQL UI display numbers greater than 1000 with u00A0 as grouping separator. Problem exists when server locale has no-breaking space as separator. (for example pl_PL) This patch turns off grouping and remove this separator. The problem starts with this PR. https://github.com/apache/spark/pull/12425/files#diff-803f475b01acfae1c5c96807c2ea9ddcR125 ## How was this patch tested? Manual UI tests. Screenshot attached.  Author: Maciej Brynski <[email protected]> Closes #14142 from maver1ck/master. (cherry picked from commit 83879eb) Signed-off-by: Sean Owen <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Sep 19, 2016
## What changes were proposed in this pull request? Currently, the SQL metrics looks like `number of rows: 111111111111`, it's very hard to read how large the number is. So a separator was added by #12425, but removed by #14142, because the separator is weird in some locales (for example, pl_PL), this PR will add that back, but always use "," as the separator, since the SQL UI are all in English. ## How was this patch tested? Existing tests.  Author: Davies Liu <[email protected]> Closes #15106 from davies/metric_sep. (cherry picked from commit e063206) Signed-off-by: Davies Liu <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Sep 19, 2016
## What changes were proposed in this pull request? Currently, the SQL metrics looks like `number of rows: 111111111111`, it's very hard to read how large the number is. So a separator was added by #12425, but removed by #14142, because the separator is weird in some locales (for example, pl_PL), this PR will add that back, but always use "," as the separator, since the SQL UI are all in English. ## How was this patch tested? Existing tests.  Author: Davies Liu <[email protected]> Closes #15106 from davies/metric_sep.
wgtmac
pushed a commit
to wgtmac/spark
that referenced
this pull request
Sep 19, 2016
## What changes were proposed in this pull request? Currently, the SQL metrics looks like `number of rows: 111111111111`, it's very hard to read how large the number is. So a separator was added by apache#12425, but removed by apache#14142, because the separator is weird in some locales (for example, pl_PL), this PR will add that back, but always use "," as the separator, since the SQL UI are all in English. ## How was this patch tested? Existing tests.  Author: Davies Liu <[email protected]> Closes apache#15106 from davies/metric_sep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Spark SQL UI display numbers greater than 1000 with u00A0 as grouping separator.
Problem exists when server locale has no-breaking space as separator. (for example pl_PL)
This patch turns off grouping and remove this separator.
The problem starts with this PR.
https://github.com/apache/spark/pull/12425/files#diff-803f475b01acfae1c5c96807c2ea9ddcR125
How was this patch tested?
Manual UI tests. Screenshot attached.