-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-16303][DOCS][EXAMPLES][WIP] Updated SQL programming guide and examples #14119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@liancheng could you, please, review this PR? |
| // spark is an existing HiveContext | ||
| spark.refreshTable("my_table") | ||
| // spark is an existing SparkSession | ||
| spark.catalog.refreshTable("my_table") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it the correct way to refresh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
|
test this please |
|
add to whitelist |
|
Test build #62092 has finished for PR 14119 at commit
|
|
Since you've added |
| @@ -0,0 +1,192 @@ | |||
| package org.apache.spark.examples.sql; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add Apache license header.
|
This looks pretty good! Only found a few minor issues. Thanks for working on it! |
|
Can we add actual stdout output after each |
…les. Changes after the initial review
|
Thanks for the review, I really appreciate. I tried to take into account all comments and update the PR accordingly. Summary of the updates
Open questions
|
|
Test build #62192 has finished for PR 14119 at commit
|
- Hard-coded Spark SQL sample snippets were moved into source files under examples sub-project. - Removed the inconsistency between Scala and Java Spark SQL examples - Scala and Java Spark SQL examples were updated The work is still in progress. All involved examples were tested manually. An additional round of testing will be done after the code review.  Author: aokolnychyi <[email protected]> Closes #14119 from aokolnychyi/spark_16303. (cherry picked from commit 772c213) Signed-off-by: Cheng Lian <[email protected]>
|
LGTM, I've merged this to master and branch-2.0. Thanks for working on this! I only observed one weird rendering case caused by the missing blank lines before Could you please remove the WIP tag from the PR title? (I've removed it manually while merging this PR.) |
What changes were proposed in this pull request?
How was this patch tested?
The work is still in progress. All involved examples were tested manually. An additional round of testing will be done after the code review.