[SPARK-16457] [SQL] Fix Wrong Messages when CTAS with a Partition By Clause #14113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ctx) | ||
| } | ||
| // Hive does not allow to use a CTAS statement to create a partitioned table. | ||
| if (tableDesc.partitionColumnNames.nonEmpty) { |
Member
Author
There was a problem hiding this comment.
This is a dead code if we do not change the order.
|
Test build #62013 has finished for PR 14113 at commit
|
Member
Author
|
retest this please |
|
Test build #62026 has finished for PR 14113 at commit
|
Member
Author
|
wrong branch... Let me revert it back |
|
Test build #62046 has finished for PR 14113 at commit
|
|
Test build #62045 has finished for PR 14113 at commit
|
Member
Author
|
retest this please |
|
Test build #62181 has finished for PR 14113 at commit
|
Member
Author
|
cc @cloud-fan |
Member
Author
|
retest this please |
Member
Author
|
cc @cloud-fan This is not contained in #14482. Should I leave it open? or you will merge it into the PR? |
|
Test build #63237 has finished for PR 14113 at commit
|
Contributor
|
can you update it? thanks! |
Member
Author
|
Will update it tonight. Thanks! |
Contributor
|
LGTM, pending jenkins |
|
Test build #63343 has finished for PR 14113 at commit
|
Contributor
|
thanks, merging to master and 2.0! |
asfgit
pushed a commit
that referenced
this pull request
Aug 8, 2016
…lause #### What changes were proposed in this pull request? When doing a CTAS with a Partition By clause, we got a wrong error message. For example, ```SQL CREATE TABLE gen__tmp PARTITIONED BY (key string) AS SELECT key, value FROM mytable1 ``` The error message we get now is like ``` Operation not allowed: Schema may not be specified in a Create Table As Select (CTAS) statement(line 2, pos 0) ``` However, based on the code, the message we should get is like ``` Operation not allowed: A Create Table As Select (CTAS) statement is not allowed to create a partitioned table using Hive's file formats. Please use the syntax of "CREATE TABLE tableName USING dataSource OPTIONS (...) PARTITIONED BY ...\" to create a partitioned table through a CTAS statement.(line 2, pos 0) ``` Currently, partitioning columns is part of the schema. This PR fixes the bug by changing the detection orders. #### How was this patch tested? Added test cases. Author: gatorsmile <[email protected]> Closes #14113 from gatorsmile/ctas. (cherry picked from commit ab12690) Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When doing a CTAS with a Partition By clause, we got a wrong error message.
For example,
The error message we get now is like
However, based on the code, the message we should get is like
Currently, partitioning columns is part of the schema. This PR fixes the bug by changing the detection orders.
How was this patch tested?
Added test cases.