[SPARK-16448] RemoveAliasOnlyProject should not remove alias with metadata #14106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #61986 has finished for PR 14106 at commit
|
|
Test build #62009 has finished for PR 14106 at commit
|
Member
|
LGTM |
| // Check if projectList in the Project node has the same attribute names and ordering | ||
| // as its child node. | ||
| /** | ||
| * Returns true if the project list is semantically same with child output, after strip alias on |
Contributor
There was a problem hiding this comment.
Nit: "... same with ..." => "... same as ..."
Contributor
|
LGTM except for some minor comments. |
|
Test build #62248 has finished for PR 14106 at commit
|
Contributor
|
Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Aliaswith metadata is not a no-op and we should not strip it inRemoveAliasOnlyProjectrule.This PR also did some improvement for this rule:
alias-only. Now we allow the project list to be partially aliased.How was this patch tested?
new
RemoveAliasOnlyProjectSuite