[SPARK-16385][core] Catch correct exception when calling method via reflection. #14056
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eflection. Using "Method.invoke" causes an exception to be throw, not an error, so Utils.waitForProcess() was always throwing an exception when run on Java 7.
vanzin
changed the title
Member
|
Dang it, my fault. Yes that's the right change, sorry. |
|
Test build #61786 has finished for PR 14056 at commit
|
Contributor
Author
|
Merging to master / 2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jul 5, 2016
…eflection. Using "Method.invoke" causes an exception to be thrown, not an error, so Utils.waitForProcess() was always throwing an exception when run on Java 7. Author: Marcelo Vanzin <[email protected]> Closes #14056 from vanzin/SPARK-16385. (cherry picked from commit 59f9c1b) Signed-off-by: Marcelo Vanzin <[email protected]>
zzcclp
added a commit
to zzcclp/spark
that referenced
this pull request
Jul 6, 2016
Member
|
Merged to 1.6 too |
asfgit
pushed a commit
that referenced
this pull request
Jul 11, 2016
…eflection. Using "Method.invoke" causes an exception to be thrown, not an error, so Utils.waitForProcess() was always throwing an exception when run on Java 7. Author: Marcelo Vanzin <[email protected]> Closes #14056 from vanzin/SPARK-16385. (cherry picked from commit 59f9c1b) Signed-off-by: Sean Owen <[email protected]>
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Jul 12, 2016
…eflection. Using "Method.invoke" causes an exception to be thrown, not an error, so Utils.waitForProcess() was always throwing an exception when run on Java 7. Author: Marcelo Vanzin <[email protected]> Closes apache#14056 from vanzin/SPARK-16385. (cherry picked from commit 59f9c1b) Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit 702178d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using "Method.invoke" causes an exception to be thrown, not an error, so
Utils.waitForProcess() was always throwing an exception when run on Java 7.