[SPARK-16368] [SQL] Fix Strange Errors When Creating View With Unmatched Column Num #14047
Conversation
| } | ||
| } | ||
|
|
||
| test("create view with mismatched schema") { |
There was a problem hiding this comment.
Did you copy the tests? Could you file a JIRA issue to get rid of the duplication at the very least? Thanks.
There was a problem hiding this comment.
This is for CREATE VIEW Another is for CREATE TEMP VIEW. They are testing different code paths.
There was a problem hiding this comment.
Without enabling Hive supports, we are unable to CREATE VIEW and then SELECT VIEW.
There was a problem hiding this comment.
Yes. You're right. I must've overlooked this no-so-little difference. Is temporary the only difference between the tests? Could we have a template test method to generate proper versions for the case? (even if it were too much for this change, it'd pave the way for more tests like this in the future). We could also have a follow-up change after this one is committed. WDYT @srowen @rxin? Is this worth the effort? I'm concerned with this duplication.
There was a problem hiding this comment.
Eventually, we will remove the functionality gap. At that moment, we need to clean the test suites and combine all the duplicate test cases.
|
Test build #61733 has finished for PR 14047 at commit
|
|
Merging in master/2.0. |
…ed Column Num #### What changes were proposed in this pull request? When creating a view, a common user error is the number of columns produced by the `SELECT` clause does not match the number of column names specified by `CREATE VIEW`. For example, given Table `t1` only has 3 columns ```SQL create view v1(col2, col4, col3, col5) as select * from t1 ``` Currently, Spark SQL reports the following error: ``` requirement failed java.lang.IllegalArgumentException: requirement failed at scala.Predef$.require(Predef.scala:212) at org.apache.spark.sql.execution.command.CreateViewCommand.run(views.scala:90) ``` This error message is very confusing. This PR is to detect the error and issue a meaningful error message. #### How was this patch tested? Added test cases Author: gatorsmile <[email protected]> Closes #14047 from gatorsmile/viewMismatchedColumns. (cherry picked from commit ab05db0) Signed-off-by: Reynold Xin <[email protected]>
4 participants
What changes were proposed in this pull request?
When creating a view, a common user error is the number of columns produced by the
SELECTclause does not match the number of column names specified byCREATE VIEW.For example, given Table
t1only has 3 columnsCurrently, Spark SQL reports the following error:
This error message is very confusing. This PR is to detect the error and issue a meaningful error message.
How was this patch tested?
Added test cases