-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-16214] [Examples] fix the denominator of SparkPi #13910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
As the iteration number is n - 1, the denominator would also be n, |
|
Get ready to receive a comment suggesting following https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark.. I believe this is not a
|
|
Nah @HyukjinKwon I think this is a simple fix that's self-contained here. Either the iterations or the estimate formula is wrong here and that's all there is to it. |
|
@yanghaogn since you already made a JIRA, connect it in the title please. It is not resolved |
|
Jenkins test this please |
|
@srowen It's been related now |
|
Not quite, see https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark and other PRs |
|
Test build #61261 has finished for PR 13910 at commit
|
As explained in #2874 ``` The max size of the input seq was Int.MaxValue - 1 ```
|
I see, maybe better to just fix the denominator then. |
change the denominator
|
Jenkins retest this please |
|
Test build #61268 has finished for PR 13910 at commit
|
## What changes were proposed in this pull request? reduce the denominator of SparkPi by 1 ## How was this patch tested? integration tests Author: 杨浩 <[email protected]> Closes #13910 from yanghaogn/patch-1. (cherry picked from commit b452026) Signed-off-by: Sean Owen <[email protected]>
## What changes were proposed in this pull request? reduce the denominator of SparkPi by 1 ## How was this patch tested? integration tests Author: 杨浩 <[email protected]> Closes #13910 from yanghaogn/patch-1. (cherry picked from commit b452026) Signed-off-by: Sean Owen <[email protected]>
|
Merged to master/2.0/1.6 |
## What changes were proposed in this pull request? reduce the denominator of SparkPi by 1 ## How was this patch tested? integration tests Author: 杨浩 <[email protected]> Closes apache#13910 from yanghaogn/patch-1. (cherry picked from commit b452026) Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit 22a496d)
What changes were proposed in this pull request?
reduce the denominator of SparkPi by 1
How was this patch tested?
integration tests