Skip to content

[SPARK-1667] Jobs never finish successfully once bucket file missing occurred #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-1667] Jobs never finish successfully once bucket file missing occurred #1383

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fc1ba0
Modify for SPARK-1667
sarutak Jul 12, 2014
c2044d6
Modified Utils.scala to handle IOException as fatal
sarutak Jul 12, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/src/main/scala/org/apache/spark/util/Utils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1223,6 +1223,8 @@ private[spark] object Utils extends Logging {
/** Returns true if the given exception was fatal. See docs for scala.util.control.NonFatal. */
def isFatalError(e: Throwable): Boolean = {
e match {
case _: IOException =>
Copy link
Contributor

@rxin rxin Jul 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some inline comment explaining why we are catching this IOException here?

true
case NonFatal(_) | _: InterruptedException | _: NotImplementedError | _: ControlThrowable =>
false
case _ =>
Expand Down