[SPARK-16036][SPARK-16037][SPARK-16034][SQL] Follow up code clean up and improvement #13766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhuai
changed the title
| None | ||
| } else { | ||
| // Note: The parser (visitPartitionSpec in AstBuilder) already turns | ||
| // keys in partition to their lowercase forms. |
Contributor
Author
There was a problem hiding this comment.
|
Test build #60794 has finished for PR 13766 at commit
|
Contributor
|
LGTM |
Contributor
Author
|
Thanks. I am merging this to master and branch 2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jun 20, 2016
…and improvement ## What changes were proposed in this pull request? This PR is the follow-up PR for https://github.com/apache/spark/pull/13754/files and #13749. I will comment inline to explain my changes. ## How was this patch tested? Existing tests. Author: Yin Huai <[email protected]> Closes #13766 from yhuai/caseSensitivity. (cherry picked from commit 6d0f921) Signed-off-by: Yin Huai <[email protected]>
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Jun 20, 2016
…to data source tables ## What changes were proposed in this pull request? This PR adds the static partition support to INSERT statement when the target table is a data source table. ## How was this patch tested? New tests in InsertIntoHiveTableSuite and DataSourceAnalysisSuite. **Note: This PR is based on apache#13766. The last commit is the actual change.** Author: Yin Huai <[email protected]> Closes apache#13769 from yhuai/SPARK-16030-1.
asfgit
pushed a commit
that referenced
this pull request
Jun 20, 2016
…to data source tables ## What changes were proposed in this pull request? This PR adds the static partition support to INSERT statement when the target table is a data source table. ## How was this patch tested? New tests in InsertIntoHiveTableSuite and DataSourceAnalysisSuite. **Note: This PR is based on #13766. The last commit is the actual change.** Author: Yin Huai <[email protected]> Closes #13769 from yhuai/SPARK-16030-1. (cherry picked from commit 905f774) Signed-off-by: Cheng Lian <[email protected]>
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Jun 21, 2016
…ases for by position resolution ## What changes were proposed in this pull request? This PR migrates some test cases introduced in apache#12313 as a follow-up of apache#13754 and apache#13766. These test cases cover `DataFrameWriter.insertInto()`, while the former two only cover SQL `INSERT` statements. Note that the `testPartitionedTable` utility method tests both Hive SerDe tables and data source tables. ## How was this patch tested? N/A Author: Cheng Lian <[email protected]> Closes apache#13810 from liancheng/spark-16037-follow-up-tests.
asfgit
pushed a commit
that referenced
this pull request
Jun 21, 2016
…ases for by position resolution ## What changes were proposed in this pull request? This PR migrates some test cases introduced in #12313 as a follow-up of #13754 and #13766. These test cases cover `DataFrameWriter.insertInto()`, while the former two only cover SQL `INSERT` statements. Note that the `testPartitionedTable` utility method tests both Hive SerDe tables and data source tables. ## How was this patch tested? N/A Author: Cheng Lian <[email protected]> Closes #13810 from liancheng/spark-16037-follow-up-tests. (cherry picked from commit f4a3d45) Signed-off-by: Yin Huai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is the follow-up PR for https://github.com/apache/spark/pull/13754/files and #13749. I will comment inline to explain my changes.
How was this patch tested?
Existing tests.