[SPARK-15159][SPARKR] SparkSession roxygen2 doc, programming guide, example updates #13751
Conversation
|
Test build #60756 has finished for PR 13751 at commit
|
docs/sparkr.md
Outdated
| machine learning using MLlib. | ||
|
|
||
| # SparkR DataFrames | ||
| # SparkDataFrames |
There was a problem hiding this comment.
Oh, @felixcheung
This will make broken links.
For example, DataFrame.R line 38,
@seealso \url{https://spark.apache.org/docs/latest/sparkr.html#sparkr-dataframes}
You should fix together. I'm not sure the other links outside of the R module.
|
@felixcheung LGTM excepts a few comments. |
|
@dongjoon-hyun thanks for the thorough review! |
|
Test build #60845 has finished for PR 13751 at commit
|
R/pkg/R/schema.R
Outdated
| #' rdd <- lapply(parallelize(sc, 1:10), function(x) { list(x, as.character(x)) }) | ||
| #' schema <- structType(structField("a", "integer"), structField("b", "string")) | ||
| #' df <- createDataFrame(sqlCtx, rdd, schema) | ||
| #' df <- createDataFrame(rdd, schema) |
There was a problem hiding this comment.
nit: there is no rdd defined here. We can just use createDataFrame(iris, schema) or dapply for this example
|
Changes look pretty good to me. Thanks -- I just had a couple of minor comments. Also I think we should look at #13592 to make sure there are no other inconsistencies in how we describe SparkSession, Catalogs etc. |
|
Test build #60865 has finished for PR 13751 at commit
|
|
LGTM. Merging this to master, branch-2.0 |
…xample updates ## What changes were proposed in this pull request? roxygen2 doc, programming guide, example updates ## How was this patch tested? manual checks shivaram Author: Felix Cheung <[email protected]> Closes #13751 from felixcheung/rsparksessiondoc. (cherry picked from commit 359c2e8) Signed-off-by: Shivaram Venkataraman <[email protected]>
5 participants
What changes were proposed in this pull request?
roxygen2 doc, programming guide, example updates
How was this patch tested?
manual checks
@shivaram