Skip to content

Conversation

@maropu
Copy link
Member

@maropu maropu commented Jun 17, 2016

What changes were proposed in this pull request?

This is rework based on #10116

How was this patch tested?

Manually checked

@maropu
Copy link
Member Author

maropu commented Jun 17, 2016

This pr add a new metric as follows;
screen shot 2016-06-17 at 10 07 04 pm

@SparkQA
Copy link

SparkQA commented Jun 17, 2016

Test build #60708 has finished for PR 13736 at commit 9d2d40d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class SQLDiffMetric(metricType: String, startTime: Long = 0L, initValue: Long = 0L)

@maropu
Copy link
Member Author

maropu commented Jun 18, 2016

I'm looking into this to fix bugs...

@maropu maropu force-pushed the SPARK-12113 branch 2 times, most recently from 0c99ccf to 505c05b Compare June 19, 2016 06:22
@maropu
Copy link
Member Author

maropu commented Jun 19, 2016

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jun 19, 2016

Test build #60796 has finished for PR 13736 at commit 505c05b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 19, 2016

Test build #60801 has finished for PR 13736 at commit 505c05b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 19, 2016

Test build #60798 has finished for PR 13736 at commit 0c99ccf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member Author

maropu commented Jun 19, 2016

@rxin okay, ready to review. After the v2.0 release, plz check this.

@SparkQA
Copy link

SparkQA commented Aug 19, 2016

Test build #64051 has finished for PR 13736 at commit 7ccd981.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 18, 2016

Test build #68862 has finished for PR 13736 at commit 10dca0e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member Author

maropu commented Jan 10, 2017

I think this pr got stale, so I'll close this, thanks.

@maropu maropu closed this Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants