[SPARK-15892][ML] Backport correctly merging AFTAggregators to branch 1.6 #13725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @jkbradley I am sure that this tests this patch correctly anyway but less sure that checking |
|
Test build #60676 has finished for PR 13725 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Jun 18, 2016
… 1.6 ## What changes were proposed in this pull request? This PR backports #13619. The original test added in branch-2.0 was failed in branch-1.6. This seems because the behaviour was changed in 101663f. This was failure while calculating Euler's number which ends up with a infinity regardless of this path. So, I brought the dataset from `AFTSurvivalRegressionExample` to make sure this is working and then wrote the test. I ran the test before/after creating empty partitions. `model.scale` becomes `1.0` with empty partitions and becames `1.547` without them. After this patch, this becomes always `1.547`. ## How was this patch tested? Unit test in `AFTSurvivalRegressionSuite`. Author: hyukjinkwon <[email protected]> Closes #13725 from HyukjinKwon/SPARK-15892-1-6.
Contributor
|
LGTM. Merged into branch-1.6. Thanks for backporting the patch! |
Member
Author
|
I am closing this as this is merged. Thank you @mengxr again! |
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Jun 20, 2016
… 1.6 ## What changes were proposed in this pull request? This PR backports apache#13619. The original test added in branch-2.0 was failed in branch-1.6. This seems because the behaviour was changed in apache@101663f. This was failure while calculating Euler's number which ends up with a infinity regardless of this path. So, I brought the dataset from `AFTSurvivalRegressionExample` to make sure this is working and then wrote the test. I ran the test before/after creating empty partitions. `model.scale` becomes `1.0` with empty partitions and becames `1.547` without them. After this patch, this becomes always `1.547`. ## How was this patch tested? Unit test in `AFTSurvivalRegressionSuite`. Author: hyukjinkwon <[email protected]> Closes apache#13725 from HyukjinKwon/SPARK-15892-1-6. (cherry picked from commit fd05389)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR backports #13619.
The original test added in branch-2.0 was failed in branch-1.6.
This seems because the behaviour was changed in 101663f. This was failure while calculating Euler's number which ends up with a infinity regardless of this path.
So, I brought the dataset from
AFTSurvivalRegressionExampleto make sure this is working and then wrote the test.I ran the test before/after creating empty partitions.
model.scalebecomes1.0with empty partitions and becames1.547without them.After this patch, this becomes always
1.547.How was this patch tested?
Unit test in
AFTSurvivalRegressionSuite.