[SPARK-15992] [MESOS] Refactor MesosCoarseGrainedSchedulerBackend offer consideration #13715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the pull request, but the refactoring seems to have made it more difficult to read? |
Contributor
Author
|
I broke something in the test suite, evaluating and I'll open this back in a bit |
| def calculateUsableResources(sc: SparkContext, availableCpus: Int, availableMem: Int): | ||
| Option[(Int, Int)] = { | ||
| val desiredMemory = executorMemory(sc) | ||
| val desiredCpu = executorCores(availableCpus) |
Contributor
There was a problem hiding this comment.
I like the idea, but it does make it harder to read. Can we refactor so we can collapse global and resource limits, and introduce like a case class for each condition, where it knows how to verify and logs error message when it doesn't match?
I think it makes adding and understanding how offers are matched better.
Contributor
Author
There was a problem hiding this comment.
I can do that. Will be a few weeks before I can tackle this again though.
Contributor
|
ok to test |
|
Test build #60997 has finished for PR 13715 at commit
|
Member
|
(ping @drcrallen) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The offer acceptance workflow is a little hard to follow and not very extensible for future considerations for offers. This is a patch that makes the workflow a little more explicit in its handling of offer resources.