[SPARK-15782] [YARN] Fix spark.jars and spark.yarn.dist.jars handling #13709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM since I already tested the 2.10 changes yesterday. |
Contributor
|
ok to test |
|
Test build #60652 has finished for PR 13709 at commit
|
Contributor
|
retest this please |
Contributor
There was a problem hiding this comment.
can you add a java doc on this and explain what happens in YARN vs other modes?
|
Test build #60661 has finished for PR 13709 at commit
|
nezihyigitbasi
force-pushed
the
SPARK-15782
branch
from
34cb915 to
699e269
Compare
Contributor
Author
|
added javadoc for |
|
Test build #60666 has finished for PR 13709 at commit
|
Contributor
|
Merging to master / 2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jun 17, 2016
When `--packages` is specified with spark-shell the classes from those packages cannot be found, which I think is due to some of the changes in SPARK-12343. Tested manually with both scala 2.10 and 2.11 repls. vanzin davies can you guys please review? Author: Marcelo Vanzin <[email protected]> Author: Nezih Yigitbasi <[email protected]> Closes #13709 from nezihyigitbasi/SPARK-15782. (cherry picked from commit 63470af) Signed-off-by: Marcelo Vanzin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When
--packagesis specified with spark-shell the classes from those packages cannot be found, which I think is due to some of the changes in SPARK-12343.How was this patch tested?
Tested manually with both scala 2.10 and 2.11 repls.
@vanzin @davies can you guys please review?