[SPARK-15978] [SQL] improve 'show tables' command related codes #13695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you update the title to say more about the command? (show table here). |
bomeng
changed the title
|
Test build #60614 has finished for PR 13695 at commit
|
bomeng
changed the title
Contributor
Author
|
@rxin could you please review it again? |
Contributor
|
LGTM |
Contributor
|
Merging into master 2.0 |
asfgit
pushed a commit
that referenced
this pull request
Jun 16, 2016
## What changes were proposed in this pull request? I've found some minor issues in "show tables" command: 1. In the `SessionCatalog.scala`, `listTables(db: String)` method will call `listTables(formatDatabaseName(db), "*")` to list all the tables for certain db, but in the method `listTables(db: String, pattern: String)`, this db name is formatted once more. So I think we should remove `formatDatabaseName()` in the caller. 2. I suggest to add sort to listTables(db: String) in InMemoryCatalog.scala, just like listDatabases(). ## How was this patch tested? The existing test cases should cover it. Author: bomeng <[email protected]> Closes #13695 from bomeng/SPARK-15978. (cherry picked from commit bbad4cb) Signed-off-by: Andrew Or <[email protected]>
Contributor
Author
|
Thanks for merging ! |
LuciferYang
pushed a commit
that referenced
this pull request
Jan 26, 2024
### What changes were proposed in this pull request? The pr aims to upgrade `Netty` from `4.1.100.Final` to `4.1.106.Final`. ### Why are the changes needed? - To bring the latest bug fixes Automatically close Http2StreamChannel when Http2FrameStreamExceptionreaches end ofChannelPipeline ([#13651](netty/netty#13651)) Symbol not found: _netty_jni_util_JNI_OnLoad ([#13695](netty/netty#13728)) - 4.1.106.Final release note: https://netty.io/news/2024/01/19/4-1-106-Final.html - 4.1.105.Final release note: https://netty.io/news/2024/01/16/4-1-105-Final.html - 4.1.104.Final release note: https://netty.io/news/2023/12/15/4-1-104-Final.html - 4.1.103.Final release note: https://netty.io/news/2023/12/13/4-1-103-Final.html - 4.1.101.Final release note: https://netty.io/news/2023/11/09/4-1-101-Final.html ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #44384 from panbingkun/SPARK-46432. Lead-authored-by: panbingkun <[email protected]> Co-authored-by: panbingkun <[email protected]> Signed-off-by: yangjie01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I've found some minor issues in "show tables" command:
SessionCatalog.scala,listTables(db: String)method will calllistTables(formatDatabaseName(db), "*")to list all the tables for certain db, but in the methodlistTables(db: String, pattern: String), this db name is formatted once more. So I think we should removeformatDatabaseName()in the caller.How was this patch tested?
The existing test cases should cover it.