Revert "Incorrectly merged AFTAggregator with zero total count" for branch-1.6 #13630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @jkbradley and @zzcclp |
|
Test build #60377 has finished for PR 13630 at commit
|
Member
Author
|
It seems this should be reverted first. Closing this for now (see #13619). |
HyukjinKwon
changed the title
Member
Author
|
@jkbradley I will leave this open just in case. Please feel free to do it yourself or merge this. |
|
Test build #60463 has finished for PR 13630 at commit
|
Member
Author
|
@mengxr @yanboliang Could you please take a look? The build against branch-1.6 is being failed due to this. |
Contributor
|
ping @mengxr @yanboliang @jkbradley |
Member
|
My apologies for the slow response. I just reverted it manually in commit 2f3e327 Thank you for pinging! Could you please close this issue, but send a follow up with the backport for branch-1.6? |
Member
Author
|
Sure! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#13619 was merged into master, branch-2.0 but branch-1.6 as well.
This is currently being failed due to the use of
sparkinstead ofsqlContextbut it even fails after changing this tosqlContext.It seems the reason is the behaviour was changed in 101663f.
How was this patch tested?
Jenkins tests.