[SPARK-15204][SQL] improve nullability inference for Aggregator #13532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
cc @cloud-fan |
|
Test build #60068 has finished for PR 13532 at commit
|
| outputEncoder.deserializer.dataType, | ||
| outputType) | ||
| outputType, | ||
| outputNullable) |
Contributor
There was a problem hiding this comment.
I think we can just do: !outputEncoder.flat || outputEncoder.schema.head.nullable
|
Test build #60083 has finished for PR 13532 at commit
|
Contributor
|
can we wait for #13553? thanks! |
|
Test build #61667 has finished for PR 13532 at commit
|
| val ds1 = Seq(1, 3, 2, 5).toDS() | ||
| assert(ds1.select(typed.sum((i: Int) => i)).schema.head.nullable === false) | ||
| val ds2 = Seq(AggData(1, "a"), AggData(2, "a")).toDS() | ||
| assert(ds2.groupByKey(_.b).agg(SeqAgg.toColumn).schema(1).nullable === true) |
Contributor
There was a problem hiding this comment.
should we use ds.select for all tests? And we should also test String, which is flat but nullable.
Contributor
Author
There was a problem hiding this comment.
the last assert with NameAgg tests String as output of the Aggregator. is that good enough?
|
Test build #61697 has finished for PR 13532 at commit
|
Contributor
|
merging to master, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TypedAggregateExpression sets nullable based on the schema of the outputEncoder
How was this patch tested?
Add test in DatasetAggregatorSuite