Skip to content

[SPARK-15776][SQL] Type coercion incorrect #13524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-15776][SQL] Type coercion incorrect #13524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acef5de
Type coercion incorrect
Sephiroth-Lin Jun 6, 2016
e396735
Add UT
Sephiroth-Lin Jun 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@ object TypeCoercion {
DecimalPrecision ::
BooleanEquality ::
StringToIntegralCasts ::
Division ::
Copy link
Contributor

@hvanhovell hvanhovell Jun 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure: are you moving the Division rule above the FunctionArgumentConversion rule in order to pass correct double arguments to functions? If so, could you add a test for this?

FunctionArgumentConversion ::
CaseWhenCoercion ::
IfCoercion ::
Copy link
Contributor

@cloud-fan cloud-fan Jun 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of switching orders, can we spend some more time to make these rules non-order-sensitive? thanks

Division ::
PropagateTypes ::
ImplicitTypeCasts ::
DateTimeOperations ::
Expand Down
15 changes: 15 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2843,4 +2843,19 @@ class SQLQuerySuite extends QueryTest with SharedSQLContext {
sql(s"SELECT '$literal' AS DUMMY"),
Row(s"$expected") :: Nil)
}

test("SPARK-15776: Type coercionn incorrect") {
Seq(
(1, 11),
(3, 25),
(5, 37)
).toDF("k", "v").createOrReplaceTempView("tc")

// If Division is after FunctionArgumentConversion then for the first query it's output
// data type is bigint and second is double. But actually both these two query it's
// output data type should be double.
checkAnswer(
sql("SELECT SUM(CASE WHEN k in (3, 5) THEN v / 10 ELSE 0 END) FROM tc"),
sql("SELECT SUM(CASE WHEN k in (3, 5) THEN v / 10.0 ELSE 0 END) FROM tc"))
}
}